Allow empty log lines to be sent from the worker #2915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor log message handling to allow nil values and improve error validation.
Closes #2914
Description
We now allow the worker to send through empty log lines.
"Empty" in this case means 'something', the default value for the schema is now
nil
, and so""
is valid because thats the value from the worker.We still reject some messages, if the worker doesn't send anything for a LogLine message, that's still invalid.
Validation steps
This is not 1:1 demonstrable in a dev environment, because the error in Sentry is a "soft-error". There is not exception as such but rather a "error" logged to Sentry.
We never really tested for blank lines because (well 😅) it ignored them.
Applying this diff to
main
:And adding something like a
raise "hell"
toreply_with/2
atlib/lightning_web/channels/channel_helpers.ex:7
and then runmix test test/integration/web_and_worker_test.exs
; will result in a test failure.AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner
,:admin
,:editor
,:viewer
)