Added deprecation warning to Transformation.dump/load; removed ExplicitMoleculeComponent.to_json/from_json #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
- Coverage 98.52% 98.43% -0.10%
==========================================
Files 39 39
Lines 2166 2168 +2
==========================================
Hits 2134 2134
- Misses 32 34 +2 ☔ View full report in Codecov by Sentry. |
|
I need to add an explicit test for the ability to load |
IAlibay
reviewed
Jan 17, 2025
| deserialized = json.loads(content, cls=JSON_HANDLER.decoder) | ||
| try: | ||
| return cls.from_keyed_chain(keyed_chain=deserialized) | ||
| except: |
There was a problem hiding this comment.
Can we do a non-bare except here? I.e. is the error deterministic?
| @@ -121,6 +121,10 @@ def dump(self, file): | |||
| file : Union[PathLike, FileLike] | |||
| A pathlike of filelike to save this transformation to. | |||
| """ | |||
| warnings.warn( | |||
There was a problem hiding this comment.
A nice to have here would be to add a test for these warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #375, #458.
Also allows us to read
GufeTokenizables serialized previously indictrepresentation via.from_json.Tips
Since this will create a commit, it is best to make this comment when you are finished with your work.
Checklist
newsentryDevelopers certificate of origin