Apiresult #103
Apiresult #103
Conversation
| <div class="tab-pane fade in active" id="tab1default"> | ||
| <p><a href="{{ res_wiki.url }}" target="blank"/>{{ res_wiki.heading }}</p> | ||
| </div> | ||
| <div class="tab-pane fade" id="tab2default"> |
There was a problem hiding this comment.
The ids of those dropdown need be difference.
There was a problem hiding this comment.
Will you please tell about which dropdown you are talking, because as of now there is no dropdown in that script.
There was a problem hiding this comment.
Sorry, what I want to say is collapse, you could try to clicking wiki/stack on second result, then you get it.
| <li class="active"> | ||
| <a href= "#tab1default" style="color: #1b1e21" data-toggle="tab"> | ||
| <img src="../static/images/wikipedia.png"/> | ||
| </a> |
|
@AdiChat please review . |
|
Nice work 👍 You need to include the images in this pull request. You may place them beside the You may include this Wikipedia and StackOverflow results for each result from Cosmos. If you search A user may not explore all Wikipedia and StackOverflow results for all Cosmos results, so, you may use AJAX and Lazy loading. This will improve the user learning experience as it will give the opportunity to the user to explore a subsection deeper. Kindly take a look into this. 👍 |
|
@AdiChat Review. |
|
@AdiChat Review |
|
Great work 👍 You need to include the images in this pull request. Consider the results for the term "search". The Wikipedia results are fine but the StackOverflow results are the same for every result indicating that it is for the keyword "search" not for a particular result like "linear search". The UI is broken. Lower results are nested in upper results. See for the search term "search". Kindly take a look at this. 👍 |
|
@AdiChat In case of more numbers of Solutions like in
|
|
Yes, this issue will remain even if we resolve it for this case by using AJAX as there will be multiple users in production. One solution is to write a script to search a search engine like Google for keywords like This can be done for Wikipedia as well. Once done, we can update the database in a couple of months to keep new results in consideration. |
|
@AdiChat Please review |
|
@AdiChat Please Review |
|
Nice work 👍 The UI and functionality look perfect. As all search requests will be made from a static IP and as the number of users will increase, this feature state may break as requests to Wikipedia API and Google search will be restricted. A more robust solution is to crawl selected sites and use the stored data to present results. A couple of crawler code in Python are available which can be modified for our purpose. Kindly take a look into this. 👍 |
|
@AdiChat please review |
Checklist
developbranch.Which issue does this PR fix?:
fixes: #91
what this PR does?
we can search our query in wikipedia or stackoverfolw
Why do we need this PR?:
it gives relevant answer
If relevant, please include a screenshot.
