Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement in search algorithm - fuzzy search implemented #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sakshi183
Copy link

Fixes issue:
[#99]

Changes:
I have improved the search algorithm.Previously,it was not able to search queries like 'binary.search' ,'binaaary search' etc.But now it shows results for the above also.
screen shot 2018-03-11 at 11 13 19 pm
screen shot 2018-03-11 at 11 13 45 pm
screen shot 2018-03-10 at 11 17 05 pm

@Sakshi183
Copy link
Author

@AdiChat Please review the above change in the searching algorithm.I have removed popup.js and included the entire javascript in popup.html because the javascript file fuse.js (required for the fuzzy search algorithm) could not be imported in another javascript file properly.

@AdiChat
Copy link
Member

AdiChat commented Mar 12, 2018

Nice work 👍

You need to include fuse.js. You should not remove popup.js and the javascript code should be separate from the html code. You can call functions in a js file defined in another file.

Additionally, as you have changed the structure of the metadata obj, you should provide the script to generate it so, that changes are well supported.

Kindly take a look into this. 👍

@Sakshi183
Copy link
Author

@AdiChat could you please specify the exact script which is required to generate the metadata.Also I wanted to know that which script is being currently used to generate the obj.

@AdiChat
Copy link
Member

AdiChat commented Mar 18, 2018

The metadata (obj) is generated through this script.

You need to provide the script to generate the new format of the metadata (books) that you are using in this pull request. Also, you cannot include js code in html code in extensions.

Kindly take a look into this. 👍

@Sakshi183
Copy link
Author

@AdiChat The above script is in python . So , could you please specify how it is being used in offline chrome extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants