Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly created endpoint urls #405

Closed
tpazderka opened this issue Aug 10, 2017 · 0 comments
Closed

Incorrectly created endpoint urls #405

tpazderka opened this issue Aug 10, 2017 · 0 comments
Assignees
@tpazderka
Labels
bug

Comments

@tpazderka
Copy link
Collaborator

As mentioned in #375, urljoin does strip parts of path in some cases and produced incorrect endpoint URLs.

The current implementation has also some flaws...

The main issue is that if the base_url doesn't end with a slash, it is stripped by urljoin.

If the base_url ends with a slash, the currently produced URl is wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpazderka tpazderka

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tpazderka