📕🔧：correct improperly impl’d admonition #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Lewis <[email protected]>
DerekNonGeneric
changed the title
Apply Sweep Rules to your PR?
|
|
it has somewhaT been raised that the gh ones achieve greater aesthetically pleasing results at this very moment w/ minimal detriment (if being used in this setting) |
DerekNonGeneric
commented
Dec 28, 2023
Comment on lines
688
to
690
|
|
||
| The [`mount`][] command uses the `-o` option to specify additional features of the | ||
| filesystem, such as mounting it in read-only mode, user permissions assigned to |
There was a problem hiding this comment.
this eventually creates a blockquote around all that text… we do not practically want that
Suggested change
| The [`mount`][] command uses the `-o` option to specify additional features of the | |
| filesystem, such as mounting it in read-only mode, user permissions assigned to | |
| > [!NOTE] | |
| > The [`mount`][] command uses the `-o` option to specify additional features of the | |
| > filesystem, such as mounting it in read-only mode, user permissions assigned to |
There was a problem hiding this comment.
i am not going to take suggestion above; (not a really positive change for us now at least)
nice-looking gargoyle collection tho:
DerekNonGeneric
commented
Dec 28, 2023
DerekNonGeneric
commented
Dec 28, 2023
Comment on lines
685
to
687
| <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/OpenINF/GitHub-Markdown/HEAD/blockquotes/badge/light-theme/info.svg"> | ||
| <img alt="Note" src="https://raw.githubusercontent.com/OpenINF/GitHub-Markdown/HEAD/blockquotes/badge/dark-theme/info.svg"> | ||
| </picture><br /> |
There was a problem hiding this comment.
Suggested change
| <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/OpenINF/GitHub-Markdown/HEAD/blockquotes/badge/light-theme/info.svg"> | |
| <img alt="Note" src="https://raw.githubusercontent.com/OpenINF/GitHub-Markdown/HEAD/blockquotes/badge/dark-theme/info.svg"> | |
| </picture><br /> | |
| <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/OpenINF/GitHub-Markdown/HEAD/blockquotes/badge/light-theme/info.svg"> | |
| <img alt="Note" src="https://raw.githubusercontent.com/OpenINF/GitHub-Markdown/HEAD/blockquotes/badge/dark-theme/info.svg"> | |
| </picture><br /> |
There was a problem hiding this comment.
yeah, it is big;
we have a hacky alternative;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Purpose
Make a selection on the purpose(s) of your changes.
This PR contains the following:
Testing
Have you included any tests in your submission?
tests)
Breaking Changes
Have you modified any aspect public API surface (i.e., caused breakage)?
necessary)
Description
A concise recap summarily detailing what all are the changes being made.
List of any relevant issue numbers: