Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix voice requests #3

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Conversation

emphasize
Copy link
Collaborator

@emphasize emphasize commented Apr 23, 2023

outline = res['opml']['body']["outline"]
if isinstance(outline, list):
outline = outline[0]
assert isinstance(outline, dict)
if outline.get("outline"):
stations = outline["outline"]
else:
stations = outline
for entry in stations:
try:

Problem: outline is always a list (voice search/ featured media)

search comes in: [{station},{station},...]
featured comes in: [{"outline": [{station}, {station}] }, {uninteresting}]

and thus iterating over a single station (rather than a list of stations) in case of a search

This was missed last time as the review was pending.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (dev@c15e51d). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@          Coverage Diff          @@
##             dev      #3   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?       4           
  Lines          ?     166           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?     166           
  Partials       ?       0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JarbasAl JarbasAl added the bug Something isn't working label Apr 23, 2023
@JarbasAl JarbasAl merged commit a66bedb into OpenJarbas:dev Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants