-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gradle deprecation fixes testing #930
gradle deprecation fixes testing #930
Conversation
Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
Signed-off-by: Arun Venmany <[email protected]>
Hi @cherylking I have fixed most of the issues. There are more issues, but all of them are on the test builds of springboot 2. I suspect gradle 9 doesnt support springboot 2. Same tests are not showing any warning if I change spring boot version to 3 Update:- I went through spring boot gradle plugin documents and found the following
Do we need to keep supporting spring boot 2, or should we mention it in release notes that "from gradle 9, spring boot gradle plugin support is removed for version 2.7.18 or below" |
src/main/groovy/io/openliberty/tools/gradle/tasks/CompileJSPTask.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Arun Venmany <[email protected]>
@arunvenmany-ibm As discussed in scrum, we should wait until Gradle 9 has been released and then see if the springboot plugin gets updated to support Gradle 9. We should keep supporting springboot 2 if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting here that we decided any breaking changes (like the change to use the Java extension to get the source/targetCompatibility configuration) would need to be made in a separate PR and would require a bump in the major version of our plugin. This will be deferred until Gradle 9 is actually released and we can test with it and see if we can support both ways to configure those properties.
Creating a PR to test builds with --warning-mode=all and fixing issues