-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exploded loose app support #1289
Conversation
Note: This PR does not yet add this support into the current multi-module support. To avoid having this PR get any bigger, I'm going to add that in after this. |
Technical Debt
|
Tests are failing due to the requirement on ci.common changes here: OpenLiberty/ci.common#309. Once that PR is merged, the test failures should be resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments. Spent a good amt. of time just remembering some of the code.
I wonder if we should do a walkthru review to confirm the updates in slide 17?
...-maven-plugin/src/main/java/io/openliberty/tools/maven/applications/LooseWarApplication.java
Show resolved
Hide resolved
...-maven-plugin/src/main/java/io/openliberty/tools/maven/applications/LooseWarApplication.java
Outdated
Show resolved
Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/DevMojo.java
Show resolved
Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/StartDebugMojoSupport.java
Outdated
Show resolved
Hide resolved
...-maven-plugin/src/main/java/io/openliberty/tools/maven/applications/LooseWarApplication.java
Outdated
Show resolved
Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/DevMojo.java
Show resolved
Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/DevMojo.java
Show resolved
Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/StartDebugMojoSupport.java
Show resolved
Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/StartDebugMojoSupport.java
Outdated
Show resolved
Hide resolved
...-maven-plugin/src/main/java/io/openliberty/tools/maven/applications/LooseWarApplication.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More comments
liberty-maven-plugin/src/it/dev-it/resources/exploded-war-project/pom.xml
Outdated
Show resolved
Hide resolved
...n-plugin/src/it/dev-it/src/test/java/net/wasdev/wlp/test/dev/it/ExplodedLooseWarAppTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the other parts of this PR in detail, but the DevMojo changes looks fine to me.
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/DevMojo.java
Outdated
Show resolved
Hide resolved
67fa5ad
to
da1c447
Compare
71561e3
to
d692088
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments / questions. Overall, looks good. Just need some clarifications.
...n-plugin/src/it/dev-it/src/test/java/net/wasdev/wlp/test/dev/it/ExplodedLooseWarAppTest.java
Outdated
Show resolved
Hide resolved
...ty-maven-plugin/src/main/java/io/openliberty/tools/maven/applications/DeployMojoSupport.java
Show resolved
Hide resolved
...-maven-plugin/src/main/java/io/openliberty/tools/maven/applications/LooseWarApplication.java
Show resolved
Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/DevMojo.java
Outdated
Show resolved
Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/StartDebugMojoSupport.java
Show resolved
Hide resolved
d0bea75
to
170e9d5
Compare
...-maven-plugin/src/main/java/io/openliberty/tools/maven/applications/LooseWarApplication.java
Outdated
Show resolved
Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/DevMojo.java
Outdated
Show resolved
Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/StartDebugMojoSupport.java
Show resolved
Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/StartDebugMojoSupport.java
Show resolved
Hide resolved
f34bbbf
to
fe67e2f
Compare
Signed-off-by: Adam Wisniewski <[email protected]>
fe67e2f
to
d7eec1c
Compare
Signed-off-by: Adam Wisniewski [email protected]
Add support for "exploded" loose war applications.
This will: