-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the plugin build #1697
Update the plugin build #1697
Conversation
Changes: * update wrapper and wrapper used maven (3.9.2) * set proper prerequisites (aligned with deps) * put all (even transitively incoming) maven deps to proper provided scope * align maven-plugin tools (annotations and plugin) to latest 3.9 * migrate off from dead build-api * remove bad (non existent) config * gather all plugin versions to single place (there should be not plugin versions scattered across, simpler to maintain) Note: downgraded the snapshot dependency to simplify my own life, if this PR is to be merged, the snapshot dependency change should be undone.
@cstamas Can you please go ahead and undo the snapshot dependency change so that the submitted builds will run correctly? I had published the ci.common snapshot to sonatype, so I am not sure why it should complicate things locally to run with it? |
done (I use locally MRM) |
So I see the following in one of the build logs. I don't understand where some of the old versions are coming in? Should you add your workflow changes to this PR to resolve this? @cstamas |
Given warnings are emitted, the maven 3.9.2 seems to be used, but from where come your plugin versions (and those are ancient ones, m-install-p 2.5.2?) I have no idea, as no Maven 3.9.x was shipped with 2.x plugins |
best would be to see is workflow update working (build pass), if working to merge it. Then we'd have some insight more, as this may be also some mixup due MAVE_HOME (that is most probably coming from maven shipped with setup-java, that I have no idea what version is) |
Updated PR w/ latest main (workflow) updates |
Changes:
Note: downgraded the snapshot dependency to simplify my own life, if this PR is to be merged, the snapshot dependency change should be undone.