Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the plugin build #1697

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Update the plugin build #1697

merged 3 commits into from
Jun 23, 2023

Conversation

cstamas
Copy link
Contributor

@cstamas cstamas commented Jun 21, 2023

Changes:

  • update wrapper and wrapper used maven (3.9.2)
  • set proper prerequisites (aligned with deps)
  • put all (even transitively incoming) maven deps to proper provided scope
  • align maven-plugin tools (annotations and plugin) to latest 3.9
  • migrate off from dead build-api
  • remove bad (non existent) config
  • gather all plugin versions to single place (there should be not plugin versions scattered across, simpler to maintain)

Note: downgraded the snapshot dependency to simplify my own life, if this PR is to be merged, the snapshot dependency change should be undone.

Changes:
* update wrapper and wrapper used maven (3.9.2)
* set proper prerequisites (aligned with deps)
* put all (even transitively incoming) maven deps to proper provided scope
* align maven-plugin tools (annotations and plugin) to latest 3.9
* migrate off from dead build-api
* remove bad (non existent) config
* gather all plugin versions to single place (there should be not plugin versions scattered across, simpler to maintain)

Note: downgraded the snapshot dependency to simplify my own life, if this PR is to be merged, the
snapshot dependency change should be undone.
@cherylking
Copy link
Member

@cstamas Can you please go ahead and undo the snapshot dependency change so that the submitted builds will run correctly? I had published the ci.common snapshot to sonatype, so I am not sure why it should complicate things locally to run with it?

@cstamas
Copy link
Contributor Author

cstamas commented Jun 21, 2023

done (I use locally MRM)

@cherylking
Copy link
Member

So I see the following in one of the build logs. I don't understand where some of the old versions are coming in? Should you add your workflow changes to this PR to resolve this? @cstamas

Screenshot 2023-06-21 at 9 52 40 AM

@cstamas
Copy link
Contributor Author

cstamas commented Jun 21, 2023

Given warnings are emitted, the maven 3.9.2 seems to be used, but from where come your plugin versions (and those are ancient ones, m-install-p 2.5.2?) I have no idea, as no Maven 3.9.x was shipped with 2.x plugins

@cstamas
Copy link
Contributor Author

cstamas commented Jun 21, 2023

best would be to see is workflow update working (build pass), if working to merge it. Then we'd have some insight more, as this may be also some mixup due MAVE_HOME (that is most probably coming from maven shipped with setup-java, that I have no idea what version is)

@cstamas
Copy link
Contributor Author

cstamas commented Jun 22, 2023

Updated PR w/ latest main (workflow) updates

@cherylking cherylking merged commit 5c25fd6 into OpenLiberty:main Jun 23, 2023
@cstamas cstamas deleted the update-plugin branch June 23, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants