Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to MP6 and JEE10 #148

Merged
merged 19 commits into from
May 15, 2023
Merged

Update to MP6 and JEE10 #148

merged 19 commits into from
May 15, 2023

Conversation

gkwan-ibm
Copy link
Member

@gkwan-ibm gkwan-ibm commented Apr 20, 2023

address issue: OpenLiberty/guides-common#891 and OpenLiberty/guides-common#897

Review changes

  • pom.xml
    • java 11
    • jakarta is 10, microfile-profile is 6.0, and dependencies
    • LMP 3.7.1
  • server.xml
    • features version
  • index.html
    • license and features version
  • java files
    • EPL 2.0
  • License file
    • EPL 2.0

End-to-end test

  • update lgdev with version-update-mp6 branch
  • do end-to-end test and review content carefully
    • clone the version-update-mp6 branch
    • if index.html has changes, make sure the links work

@mbuamuh mbuamuh self-requested a review April 25, 2023 06:04
gkwan-ibm added 2 commits May 11, 2023 10:20
update license year only
update license year only
@gkwan-ibm
Copy link
Member Author

gkwan-ibm commented May 11, 2023

hi @mbuamuh

Would you simplify the SystemClient [getPropertiesHelper] method (

/**
* Helper method that processes the request
* @param builder
* @return
*/
protected Properties getPropertiesHelper(final Builder builder) {
try {
Response response = builder.get();
if (response.getStatus() == Status.OK.getStatusCode()) {
return response.readEntity(Properties.class);
} else {
System.err.println("Response Status is not OK.");
}
} catch (RuntimeException e) {
System.err.println("Runtime exception: " + e.getMessage());
} catch (Exception e) {
System.err.println("Exception thrown while invoking the request: "
+ e.getMessage());
}
return null;
}
) as this getPropertiesHelper? and update the class under the start directory, and verify it on AWS again?

@gkwan-ibm gkwan-ibm merged commit bcb3a5e into staging May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants