Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to MP6 and JEE10 #59

Merged
merged 6 commits into from
May 11, 2023
Merged

Update to MP6 and JEE10 #59

merged 6 commits into from
May 11, 2023

Conversation

gkwan-ibm
Copy link
Member

@gkwan-ibm gkwan-ibm commented Apr 20, 2023 •
edited
Loading

address issue: OpenLiberty/guides-common#891 and OpenLiberty/guides-common#897

Review changes

  • pom.xml
    • java 11
    • jakarta is 10, microfile-profile is 6.0, and dependencies
    • LMP 3.7.1
  • server.xml
    • features version
  • index.html
    • license and features version
  • java files
    • EPL 2.0
  • License file
    • EPL 2.0

End-to-end test

  • update lgdev with version-update-mp6 branch
  • do end-to-end test and review content carefully
    • clone the version-update-mp6 branch
    • if index.html has changes, make sure the links work

Cloud hosted test

  • generate the cloud hosted dev lab
  • do end-to-end test and review content
    • clone the version-update-mp6 branch

gkwan-ibm and others added 4 commits February 2, 2023 14:22
@gkwan-ibm
Merge pull request #58 from OpenLiberty/staging
1b5358d 
Merge staging to prod - Update LMP to 3.7.1
@gkwan-ibm
update versions
3e1f558
@jakub-pomykala
Added gitignore file and fixed superlinter failure
727825e
@jakub-pomykala
JRE8 to JRE17 replacement (#61)
ac08d0a 
* Changing from JRE8 & JRE11 to JRE11 & JRE17

* fixing failing test files check

* fixing failing check files testing
@jakub-pomykala
Copy link
Member

jakub-pomykala commented Apr 25, 2023 •
edited
Loading

address issue: OpenLiberty/guides-common#891

Review changes

  • pom.xml
    • java 11
    • jakarta is 10, microfile-profile is 6.0, and dependencies
    • LMP 3.7.1
  • server.xml
    • features version
  • index.html
    • license and features version
  • java files
    • EPL 2.0
  • License file
    • EPL 2.0

End-to-end test

  • update lgdev with version-update-mp6 branch
  • do end-to-end test and review content carefully
    • clone the version-update-mp6 branch
    • if index.html has changes, make sure the links work

Cloud hosted test

  • generate the cloud hosted dev lab
  • do end-to-end test and review content
    • clone the version-update-mp6 branch

jakub-pomykala
jakub-pomykala approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@jakub-pomykala jakub-pomykala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gkwan-ibm added 2 commits May 11, 2023 09:09
@gkwan-ibm
Update SystemEndpointIT.java
1f885e5 
update license year only
@gkwan-ibm
Update SystemEndpointIT.java
8c84420 
update as same as finish
@gkwan-ibm gkwan-ibm merged commit 593519f into staging May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakub-pomykala jakub-pomykala jakub-pomykala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkwan-ibm @jakub-pomykala