Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system service test and update to use EE10 and MP6 #54

Merged
merged 43 commits into from
May 11, 2023
Merged

Add system service test and update to use EE10 and MP6 #54

merged 43 commits into from
May 11, 2023

Conversation

gkwan-ibm
Copy link
Member

@gkwan-ibm gkwan-ibm commented Mar 15, 2023 •
edited
Loading

shin19991207 and others added 27 commits January 6, 2023 15:09
@shin19991207
create systemIT test
c2473f9
@shin19991207
Update SystemIT.java
3e4c189
@shin19991207
Update SystemIT.java
53a0cda
@shin19991207
Update SystemIT.java
f523e51
@shin19991207
Update SystemIT.java
0bb08aa
@shin19991207
Update testApp.sh
4d6a839
@shin19991207
update README
c8cfb4c
@shin19991207
Update README.adoc
eb20702
@shin19991207
Update README.adoc
478e1b5
@shin19991207
Update README.adoc
2c908c4
@shin19991207
Update README.adoc
b16b7d5
@shin19991207
Update README.adoc
9d02ef0
@gkwan-ibm
Merge branch 'staging' into system-service-test
3f07b72
@shin19991207
rename SystemIT to SystemTest
6bb2966
@shin19991207
Update SystemTest.java
108cf16
@shin19991207
Update README.adoc
0c4e95d
@gkwan-ibm
Merge branch 'staging' into system-service-test
b96a4b6
@gkwan-ibm
Merge branch 'staging' into system-service-test
1e06a9b
@shin19991207
update unit test from JUnit4 to JUnit5
f37a7df
@shin19991207
Merge branch 'system-service-test' of https://github.com/openliberty/…
1c8b532 
…guide-grpc-intro into system-service-test
@shin19991207
create RPC server unit test
4d9338f
@shin19991207
Update README.adoc
84a1c58
@shin19991207
Update README.adoc
9bb24aa
@shin19991207
update start/system/pom.xml
66f4e1d
@gkwan-ibm
dev content review (#50)
238d2d4 
* dev content review

* dev content review

* dev content review

* dev content review

* dev content review

* dev content review
@gkwan-ibm
dev content review (#51)
bc3313f
@gkwan-ibm
dev content review 2 (#52)
f6a897d 
* dev content review

* dev content review

* dev content review
@mbuamuh mbuamuh assigned mbuamuh and unassigned mbuamuh Mar 21, 2023
mbuamuh
mbuamuh requested changes Mar 21, 2023
View reviewed changes
README.adoc Show resolved Hide resolved
dmuelle
dmuelle requested changes Apr 18, 2023
View reviewed changes
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID review, let me know if you have any questions. Thanks

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
gkwan-ibm and others added 8 commits April 18, 2023 10:48
@gkwan-ibm @dmuelle
Update README.adoc
aff272b 
Co-authored-by: David Mueller <[email protected]>
@gkwan-ibm @dmuelle
Update README.adoc
4a7e317 
Co-authored-by: David Mueller <[email protected]>
@gkwan-ibm @dmuelle
Update README.adoc
57b1ae5 
Co-authored-by: David Mueller <[email protected]>
@gkwan-ibm @dmuelle
Update README.adoc
8e19f47 
Co-authored-by: David Mueller <[email protected]>
@gkwan-ibm @dmuelle
Update README.adoc
b62e995 
Co-authored-by: David Mueller <[email protected]>
@gkwan-ibm @dmuelle
Update README.adoc
5ec049f 
Co-authored-by: David Mueller <[email protected]>
@gkwan-ibm
Update README.adoc
a6c91b3
@gkwan-ibm
Update README.adoc
8c837b2
dmuelle
dmuelle reviewed Apr 18, 2023
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
gkwan-ibm and others added 2 commits April 18, 2023 15:00
dmuelle
dmuelle approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkwan-ibm
Copy link
Member Author

gkwan-ibm commented Apr 18, 2023 •
edited by ReeceNana
Loading

Review changes

  • pom.xml
    • java 11
    • jakarta is 10, microfile-profile is 6.0, and dependencies
    • LMP 3.7.1
  • server.xml
    • features version
  • java files
    • EPL 2.0
  • License file
    • EPL 2.0

End-to-end test

  • update lgdev with system-service-test branch
  • do end-to-end test and review content carefully
    • clone the system-service-test branch
    • if index.html has changes, make sure the links work

Cloud hosted test

  • generate the cloud hosted dev lab
  • do end-to-end test and review content
    • clone the system-service-test branch

@gkwan-ibm gkwan-ibm changed the title Add system service test Add system service test and update to use EE10 and MP6 Apr 18, 2023
@ReeceNana
Copy link
Contributor

Ran guide end-to-end on system-service-test branch.
No issues/errors when ran local or cloud-hosted.
Ready to merge.

  1. PR approval subject to Gilbert review
  2. Re-test locally subject to Morgan

@gkwan-ibm gkwan-ibm merged commit e521783 into staging May 11, 2023
@gkwan-ibm gkwan-ibm deleted the system-service-test branch May 17, 2023 13:23
@gkwan-ibm gkwan-ibm restored the system-service-test branch May 17, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmuelle dmuelle dmuelle approved these changes

@mbuamuh mbuamuh mbuamuh approved these changes

@yeekangc yeekangc Awaiting requested review from yeekangc

@shin19991207 shin19991207 Awaiting requested review from shin19991207

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gkwan-ibm @ReeceNana @mbuamuh @dmuelle @shin19991207