Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating SystemClient.java #238

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Conversation

jakub-pomykala
Copy link
Member

@jakub-pomykala jakub-pomykala commented Apr 24, 2023

Fix improper client closing in SystemClient class

@jakub-pomykala
Copy link
Member Author

jakub-pomykala commented Apr 25, 2023

address issue: OpenLiberty/guides-common#891

Review changes

  • pom.xml
    • java 11
    • jakarta is 10, microfile-profile is 6.0, and dependencies
    • LMP 3.7.1
  • server.xml
    • features version
  • index.html
    • license and features version
  • java files
    • EPL 2.0
  • License file
    • EPL 2.0

End-to-end test

  • update lgdev with version-update-mp6 branch
  • do end-to-end test and review content carefully
    • clone the version-update-mp6 branch
    • if index.html has changes, make sure the links work

Cloud hosted test

  • generate the cloud hosted dev lab
  • do end-to-end test and review content
    • clone the version-update-mp6 branch

@gkwan-ibm gkwan-ibm merged commit b516ed9 into version-update-mp6 Apr 25, 2023
gkwan-ibm added a commit that referenced this pull request May 11, 2023
* update versions

* Updating SystemClient.java (#238)

* Updating SystemClient.java

* updating copyright + start SystemClient

* Update SystemClient.java

* Update SystemClient.java

---------

Co-authored-by: Gilbert Kwan <[email protected]>

* remove unnecessary import statements

---------

Co-authored-by: jakub-pomykala <[email protected]>
@gkwan-ibm gkwan-ibm deleted the update-sysclient-jakub branch May 17, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants