Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to MP6.1 #59

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Update to MP6.1 #59

merged 5 commits into from
Feb 29, 2024

Conversation

gkwan-ibm
Copy link
Member

@gkwan-ibm gkwan-ibm commented Jan 30, 2024 •
edited by Ruilin-Ma
Loading

address issue: OpenLiberty/guides-common#1021

Review changes

  • pom.xml
    • microfile-profile is 6.1, and dependencies
    • LMP 3.10
    • default. should be removed
    • ports 9090,9453,9091,9454 if guide uses local kube
  • server.xml
    • feature version
  • index.html
    • feature version
  • update lgdev with version-update-mp61 branch
  • do end-to-end test and review content carefully
    • clone the version-update-mp61 branch
    • if index.html has changes, make sure the links work

Ruilin-Ma
Ruilin-Ma approved these changes Feb 27, 2024
View reviewed changes
Copy link

@Ruilin-Ma Ruilin-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the guide end-to-end on both Linux with Minikube and SN; no issues were found.

@gkwan-ibm gkwan-ibm merged commit 8b81822 into staging Feb 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruilin-Ma Ruilin-Ma Ruilin-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkwan-ibm @Ruilin-Ma