-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled developer to input PR number for lsp4ij checkout input #1014
base: main
Are you sure you want to change the base?
Enabled developer to input PR number for lsp4ij checkout input #1014
Conversation
If a developer want to check out LSP4IJ based on a Example run @TrevCraw , Please suggest the changes in the wordings |
Reference workflow runs : https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/11276704777 -- Normal push/PR builds Manually running workflow examples https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/11276799815 ( developer entered PR number 411 and LTI version 24.0.9 --> merge commit sha value is not https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/11276805354 ( developer entered PR number 500 and LTI version 24.0.9 --> merge commit sha value is https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/11276809742 -- LTI main & LSP4IJ main-- ( user entered branch name , https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/11276824366 -- ( user entered merge commit sha as an input for LSP4IJ checkout and LTI 24.0.9 ) https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/11276832458 -- ( user entered LTI 24.0.9 and LSP4IJ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Co-authored-by: Trevor Crawford <[email protected]>
Co-authored-by: Trevor Crawford <[email protected]>
Co-authored-by: Trevor Crawford <[email protected]>
I tested the changes today, You can check the build results below https://github.com/OpenLiberty/liberty-tools-intellij/actions/runs/11853422736/job/33033521118?pr=1014 -- Normal push/PR builds I can confirm that artifact names are working correct as expected. |
Fixes #998
Allowing developers to input the
PR number
for LSP4IJ checkout.I made some slight changes to the artifact name setup, but there is no effect on previous scenarios. Additionally, I have now enabled specifying the LSP4IJ branch name, tag, PR number, or commit SHA based on the input provided by the developer.