Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear JVM_TEMP_OPTIONS variable in server.bat on Windows #10289

Closed
hlhoots opened this issue Jan 6, 2020 · 0 comments · Fixed by #10290
Closed

Clear JVM_TEMP_OPTIONS variable in server.bat on Windows #10289

hlhoots opened this issue Jan 6, 2020 · 0 comments · Fixed by #10290
Assignees
@hlhoots
Labels
bug This bug is not present in a released version of Open Liberty in:Kernel/Bootstrap

Comments

@hlhoots
Copy link
Member

hlhoots commented Jan 6, 2020

Describe the bug
The server.bat script on Windows does not reset the JVM_TEMP_OPTIONS environment variable. Thus there are scenarios, where incorrect information can be cached.

Steps to Reproduce

  1. Set jvm.options in /shared folder with a large jvm string.
  2. Set jvm.options in /server folder with a large jvm string.
  3. Change either file in Fix branding to be Open Liberty rather than WebSphere Liberty #1 or Fix branding to be Open Liberty rather than WebSphere Liberty #2 to a shorter jvm string and larger jvm string should remain cached and used incorrectly by the script.

Expected behavior
The contents of the JVM_TEMP_OPTIONS variable should be cleared, re-read and built from the jvm.options files for each execution of the script.

Diagnostic information:

  • OpenLiberty Version: 20.0.0.1
@hlhoots hlhoots added the bug This bug is not present in a released version of Open Liberty label Jan 6, 2020
@hlhoots hlhoots self-assigned this Jan 6, 2020
hlhoots added a commit to hlhoots/open-liberty that referenced this issue Jan 6, 2020
@hlhoots
Issue OpenLiberty#10289: Clear jvm-temp-options var in server.bat
c9940be
@hlhoots hlhoots mentioned this issue Jan 6, 2020
Merged
hlhoots added a commit that referenced this issue Jan 8, 2020
@hlhoots
Merge pull request #10290 from hlhoots/10289-FixJVMTEMPOPTIONSBug
5d30642 
Issue #10289: Clear JVM_TEMP_OPTIONS variable in server.bat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hlhoots hlhoots

Labels
bug This bug is not present in a released version of Open Liberty in:Kernel/Bootstrap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #10289: Clear JVM_TEMP_OPTIONS variable in server.bat hlhoots/open-liberty
1 participant
@hlhoots