disallow retryInterval when fail over is enabled #10521
Conversation
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_0zPGcDyZEeqMye9II9MD-g Target locations of links might be accessible only to IBM employees. |
|
Your Open Liberty build results are ready for viewing.
|
|
The build njr-11-10521-20200121-2332 For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_0zPGcDyZEeqMye9II9MD-g |
njr-11
force-pushed
the
8610-disallow-retryInterval-when-failover-enabled-merged
branch
from
5071811 to
acee8ac
Compare
|
#run-libby-bot |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_0YiigD0dEeqMye9II9MD-g Target locations of links might be accessible only to IBM employees. |
| @@ -41,7 +41,7 @@ jndiName=JNDI name | |||
| jndiName.desc=JNDI name. | |||
|
|
|||
| missedTaskThreshold=Missed task threshold for fail over | |||
| missedTaskThreshold.desc=Amount of time beyond the expected start of a task execution to reserve for running it. Other members are prevented from running the task before the expiration of this interval. If the interval elapses without successful execution of the task, then the task execution is considered missed, enabling another member to attempt to run it. This enables fail over. | |||
| missedTaskThreshold.desc=missedTaskThreshold.desc=Amount of time beyond the expected start of a task execution to reserve for running it. Other members are prevented from running the task before the expiration of this interval. If the interval elapses without successful execution of the task or the task rolls back, then the task execution is considered missed, enabling another member to attempt to run it. This enables fail over. | |||
There was a problem hiding this comment.
looks like there's a typo at the start of the line- desc code appears twice?
The final sentence- This enables failover
What, specifically, enables failover? Need to specify - is it the process described in the previous sentence? Or missedTaskThreshold?
There was a problem hiding this comment.
Thanks for catching this. I attempted to fix this issue and the other issues that you found under
726da70
Please review and approve or let me know if further changes are needed.
| CWWKC1521.less.than.min=CWWKC1521E: Configured value {0} for {1} cannot be less than the configured value for {2}, which is {3}. | ||
| CWWKC1521.less.than.min.explanation=Configuring a larger retryInterval encourages other servers to retry the failed task instead of the server on which it failed. | ||
| CWWKC1521.less.than.min.useraction=Configure the retryInterval property so that it is larger than the missedTaskThreshold. | ||
| CWWKC1521.not.compatible=CWWKC1521E: Configuration attribute {0} is not valid when {1} is enabled. |
There was a problem hiding this comment.
change
Configuration attribute {0} is not valid when {1} is enabled
to
The {0} configuration attribute is not valid when the {1} configuration attribute is enabled.
| CWWKC1521.less.than.min.useraction=Configure the retryInterval property so that it is larger than the missedTaskThreshold. | ||
| CWWKC1521.not.compatible=CWWKC1521E: Configuration attribute {0} is not valid when {1} is enabled. | ||
| CWWKC1521.not.compatible.explanation=The specified configuration attributes are not compatible. | ||
| CWWKC1521.not.compatible.useraction=Update configuration to remove one of the configuration attributes. |
There was a problem hiding this comment.
change
Update configuration to remove one of the configuration attributes.
to
Update the configuration to remove one of the configuration attributes.
| @@ -41,7 +41,7 @@ jndiName=JNDI name | |||
| jndiName.desc=JNDI name. | |||
|
|
|||
| missedTaskThreshold=Missed task threshold for fail over | |||
| missedTaskThreshold.desc=Amount of time beyond the expected start of a task execution to reserve for running it. Other members are prevented from running the task before the expiration of this interval. If the interval elapses without successful execution of the task, then the task execution is considered missed, enabling another member to attempt to run it. This enables fail over. | |||
| missedTaskThreshold.desc=Amount of time beyond the expected start of a task execution to reserve for running it. Other members are prevented from running the task before the expiration of this interval. If the interval elapses without successful execution of the task or the task rolls back, then the task execution is considered missed, enabling another member to attempt to run it. Missed task threshold values within the supported range of 100 seconds to 9000 seconds (2.5 hours) enable failover. | |||
There was a problem hiding this comment.
change
Amount of time beyond the expected start of a task execution to reserve for running it.
to
The amount of time after the expected start of a task execution that is reserved for running the task.
There was a problem hiding this comment.
The fix for the above has been made exactly as suggested under 9d01e54
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_re-vwD08EeqMye9II9MD-g Target locations of links might be accessible only to IBM employees. |
|
Your Open Liberty build results are ready for viewing.
|
|
The build njr-11-10521-20200122-1839 For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_re-vwD08EeqMye9II9MD-g |
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_xgxZMD3jEeqMye9II9MD-g Target locations of links might be accessible only to IBM employees. |
| @@ -41,7 +41,7 @@ jndiName=JNDI name | |||
| jndiName.desc=JNDI name. | |||
|
|
|||
| missedTaskThreshold=Missed task threshold for fail over | |||
| missedTaskThreshold.desc=Amount of time beyond the expected start of a task execution to reserve for running it. Other members are prevented from running the task before the expiration of this interval. If the interval elapses without successful execution of the task, then the task execution is considered missed, enabling another member to attempt to run it. This enables fail over. | |||
| missedTaskThreshold.desc=The amount of time after the expected start of a task execution that is reserved for running the task. Other members are prevented from running the task before the expiration of this interval. If the interval elapses without successful execution of the task or the task rolls back, then the task execution is considered missed, enabling another member to attempt to run it. Missed task threshold values within the supported range of 100 seconds to 9000 seconds (2.5 hours) enable failover. | |||
There was a problem hiding this comment.
**suggested revision (removes "execution")
The amount of time after the expected start of a task that is reserved for running the task. Other members are prevented from running the task before the expiration of this interval. If the interval elapses without the task running successfully, or the task rolls back, then the task run is considered missed, enabling another member to attempt to run it. Missed task threshold values within the supported range of 100 seconds to 9000 seconds (2.5 hours) enable failover.
There was a problem hiding this comment.
Updated here:
f40a335
…m execution to be removed
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_5KwhAD3xEeqMye9II9MD-g Target locations of links might be accessible only to IBM employees. |
|
Your Open Liberty build results are ready for viewing.
|
…over-enabled-merged
|
An additional commit was added due to a merge conflict. It did not impact any of the message files. A new build is required though: |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_heK80D4mEeqMye9II9MD-g Target locations of links might be accessible only to IBM employees. |
|
The build njr-11-10521-20200123-1617 |
|
Your Open Liberty build results are ready for viewing.
|
|
The build njr-11-10521-20200123-2233 For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_heK80D4mEeqMye9II9MD-g |
|
Completed the requested L2 message review |
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Ga_XAD6tEeqMye9II9MD-g Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
Your Open Liberty build results are ready for viewing.
|
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_yB60MD7wEeqMye9II9MD-g Target locations of links might be accessible only to IBM employees. |
|
The build njr-11-10521-20200124-1436 For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_Ga_XAD6tEeqMye9II9MD-g |
|
Your Open Liberty build results are ready for viewing.
|
|
The build njr-11-10521-20200125-1030 For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_yB60MD7wEeqMye9II9MD-g |
|
Build has 1 failure, which is a duplicate of a pre-existing issue |
It should not be allowed to configure retryInterval (which is single-server only and interferes with fail over) when missed task threshold is configured to enable fail over. Reject this combination and update tests accordingly.