-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1411: Update the EclipseLink 2.6 and 2.7 binaries #1461
Issue 1411: Update the EclipseLink 2.6 and 2.7 binaries #1461
Conversation
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
#build |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_8dC3sPG9Eee7FMdg7u8gzA Target locations of links might be accessible only to IBM employees. |
The build daliasheasha-1461-20180105-0322 |
fixes #1411 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Make sure you link your issue to this pull request for the nlsprop changes and test this for DHE users
The build failed due to a known unrelated failure. The updatebinaries.gradle scripts should run successfully as long as this change exists in the environment: |
Thanks, @daliasheasha. It looks like you have made trace/logging message updates based on the ID Review, and this issue (1461) does not require ID. |
#build |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Al5wwPI9Eee7FMdg7u8gzA Target locations of links might be accessible only to IBM employees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
fixes #332 |
The build daliasheasha-1461-20180105-1835 |
Updated the 2.6 binaries and scripts to accommodate the changes that were made to Liberty recently that did not allow us to take advantage of properties that were global before and now aren't anymore.
Updated the 2.7 binaries and scripts likewise. Also, updated the 2.7 binaries to use the EclipseLink 2.7 service branch instead of the 2.7_WAS branch.
After spending some time looking at the EclipseLink messages, I noticed that we were detecting a lot more messages than expected between EclipseLink 2.6 and 2.7. It turned out that a change went into EclipseLink a while back that combined logging messages and trace messages into one file which were previously separated. The separation allowed us to exclude trace messages from translation since there is no need to translate trace. So, I went back to the EclipseLink community and asked if we could revert that change since we still need the message separation to easily distinguish between messages that need translation and messages that don't. After getting their approval, I went ahead and reverted the change in EclipseLink. Currently, the EclipseLink 2.7 and master branch have their trace and logging messages separated. I also committed changes to the messages according to the ID review.
All these updates are currently in the EclipseLink repository. I am pulling that change into Liberty now with the suggested changes to the translation messages.