DRAFT: Set Servlet Version From Bundle Wiring Capability Attribute

[volosied]

Potential fix #2 for #17952

This is needs a bit more work, however.

Comments & Questions

1. Removing the following Service-Component code (where the servlet versions originate) in the WC factory bnds:
   

   open-liberty/dev/com.ibm.ws.webcontainer.servlet.3.1.factories/bnd.bnd

   Lines 57 to 61 in 2fd4a88

   	Service-Component: \
   	com.ibm.ws.webcontainer.v31.dd; \
   	implementation:=com.ibm.ws.javaee.version.ServletVersion; \
   	provide:=com.ibm.ws.javaee.version.ServletVersion; \
   	properties:="version:Integer=31", \

   
   Causes

[ERROR ] CWWKZ0002E: An exception occurred while starting the application TestEL3.0. The exception message was: java.lang.IllegalStateException: com.ibm.wsspi.adaptable.module.UnableToAdaptException: com.ibm.ws.javaee.ddmodel.DDParser$ParseException: CWWKC2262E: The server is unable to process the 3.1 version and the http://xmlns.jcp.org/xml/ns/javaee namespace in the /WEB-INF/web.xml deployment descriptor on line 16.

This is because no maxVersion is actually set and the default (WebApp.VERSION_3_0) is selected instead :

open-liberty/dev/com.ibm.ws.javaee.ddmodel/src/com/ibm/ws/javaee/ddmodel/web/WebAppEntryAdapter.java

Lines 32 to 44 in 2fd4a88

	public synchronized void setVersion(ServiceReference<ServletVersion> versionRef) {
	this.versionRef = versionRef;
	Integer maxVersionValue = (Integer) versionRef.getProperty("version");
	maxVersion = maxVersionValue.intValue();
	}
	public synchronized void unsetVersion(ServiceReference<ServletVersion> versionRef) {
	if ( versionRef == this.versionRef ) {
	this.versionRef = null;
	this.maxVersion = DEFAULT_MAX_VERSION;
	}
	}

2. Change servlet Versions 2.7, 2.8, etc to appropriate levels? Or vice versa? (Change the spec level variables)?
   

   open-liberty/dev/com.ibm.websphere.javaee.servlet.3.0/bnd.bnd

   Line 17 in 7476e58

   javax.servlet;thread-context=true;version="2.6.0";uses:="javax.servlet.annotation,javax.servlet.descriptor",\

3. setVersion is public for the WC unit tests. I'm conflicted since I think this method shouldn't really exist or it shouldn't be public.

4. Since some unit tests for the version were removed, we should add tests in the FATs to ensure the versions are set.

[LibbyBot]

Code analysis and actions

DO NOT DELETE THIS COMMENT.

• 3 product code files were changed.
• Please describe in a separate comment how you tested your changes.

[volosied]

#build

[LibbyBot]

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_MC3oMAYJEeyB1uNHimT5CA

Target locations of links might be accessible only to IBM employees.

[LibbyBot]

Your Open Liberty build results are ready for viewing.

• Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_MC3oMAYJEeyB1uNHimT5CA/junit/index.html.
• Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_MC3oMAYJEeyB1uNHimT5CA.

[LibbyBot]

The build volosied-18326-20210825-1908
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_MC3oMAYJEeyB1uNHimT5CA
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_MC3oMAYJEeyB1uNHimT5CA

[volosied]

Closing as we went with #17952 instead. We can reopen this PR if the need arises.

[volosied]

#build

[LibbyBot]

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_71ahkH06EeykJKbDLxYjRw

Target locations of links might be accessible only to IBM employees.

[LibbyBot]

The build volosied-18326-20220124-1048
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_71ahkH06EeykJKbDLxYjRw
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_71ahkH06EeykJKbDLxYjRw