Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting FIPS work #29640

Closed
wants to merge 133 commits into from
Closed

Conversation

mshah0722
Copy link
Contributor

################################################################################################

Delete this section and fill in the remaining info from the template

ATTENTION, READ THIS: Updated July 2024

Read and understand this completely, then delete the static part of the template.

If a reviewer or merger sees this template, they should fail the review or merge.

If this code change is fixing a user-visible bug in previously released code, it MUST
have an associated issue mentioned in the PR text or description.

  • That Issue also MUST be labelled “release bug”

    This directs automation to scrape this fix for inclusion in the next release's
    list of bugs fixed.

  • The linkage between PR and Issue should use the Fixes #... syntax rather than a manual
    link via the Development widget.

Otherwise, a link to an issue or specific issue labels are optional.

For full details, please see this wiki page: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions
################################################################################################

@mshah0722
Copy link
Contributor Author

#libby
#build
#spawn.fullfat.buckets=com.ibm.ws.security.token.ltpa_fat

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=7cd11e5e-c1ad-40ff-a3a9-a85f2f8e2b05

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_WJGMoHFUEe-0ZL4JeBVc2g

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

@mshah0722
Copy link
Contributor Author

#libby
#build
#spawn.fullfat.buckets=com.ibm.ws.security.token.ltpa_fat

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=4aef3151-0f51-4e5d-9c5a-298526c2849a

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_WuXhAHIREe-0ZL4JeBVc2g

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

The build mshah0722-29640-20240912-2320
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_WJGMoHFUEe-0ZL4JeBVc2g
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_WJGMoHFUEe-0ZL4JeBVc2g

@LibbyBot
Copy link

@LibbyBot
Copy link

The build mshah0722-29640-20240913-2153
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_WuXhAHIREe-0ZL4JeBVc2g
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_WuXhAHIREe-0ZL4JeBVc2g

@mshah0722
Copy link
Contributor Author

#libby
#build
#spawn.fullfat.buckets=com.ibm.ws.security.token.ltpa_fat

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=8ae69ab7-2c00-41ca-8018-b7f155e06f94

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_nQ4uYXRREe-ZBdXWdK7Miw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

@LibbyBot
Copy link

The build mshah0722-29640-20240916-1141
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_nQ4uYXRREe-ZBdXWdK7Miw
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_nQ4uYXRREe-ZBdXWdK7Miw

@mshah0722
Copy link
Contributor Author

#libby
#build
#spawn.fullfat.buckets=com.ibm.ws.security.token.ltpa_fat

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=0a5768e9-45d3-4dc1-a42c-e79aaad4eb30

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_tWE48XXbEe-ZBdXWdK7Miw

Target locations of links might be accessible only to IBM employees.

@mshah0722
Copy link
Contributor Author

mshah0722 commented Dec 14, 2024

#libby
(view Open Liberty Delivery Requirements Verification - ✅ completed successfully!) (view Open Liberty Personal Build - ❌ completed with errors/failures.)

!build
git.clone.checkout.branch=FIPSwork
git.clone.repository.username=Malhar-Shah

#spawn.fullfat.buckets=com.ibm.ws.security.token.ltpa_fat

Note: Target locations of links might be accessible only to IBM employees.

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

1 similar comment
@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 70 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 8 infrastructure code files were changed.

  • 6 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 454 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 unit test files were changed.

  • Check that the build did not break the affected unit test suite(s).

  • 16 messages files were changed and need an L2 review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops

  • dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

  • 16 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops

  • dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops

  • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

jacobwdv and others added 5 commits December 16, 2024 13:32
….xml before server start

adding AEADBadTagException to AllowedFFDC list for tests which expect BadPaddingException

using jvm.options so that mbean invocations will use proper jvm parameters
updating server xml's with appropriate passwords, renaming serverFIPS…
@mshah0722
Copy link
Contributor Author

mshah0722 commented Dec 24, 2024

#libby
(view Open Liberty Delivery Requirements Verification - ✅ completed successfully!) (view Open Liberty Personal Build - ❌ completed with errors/failures.)

!build
git.clone.checkout.branch=FIPSwork
git.clone.repository.username=Malhar-Shah

#spawn.fullfat.buckets=com.ibm.ws.security.token.ltpa_fat

Note: Target locations of links might be accessible only to IBM employees.

Note: Target locations of links might be accessible only to IBM employees.

@mshah0722 mshah0722 requested a review from jhanders34 December 24, 2024 06:52
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 459 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 unit test files were changed.

  • Check that the build did not break the affected unit test suite(s).

  • 8 infrastructure code files were changed.

  • 9 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 70 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 16 messages files were changed and need an L2 review.

  • @OpenLiberty/message-reviewer Please review.

    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
    • dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops
  • 16 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
    • dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 459 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 unit test files were changed.

  • Check that the build did not break the affected unit test suite(s).

  • 8 infrastructure code files were changed.

  • 9 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 70 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 16 messages files were changed and need an L2 review.

  • @OpenLiberty/message-reviewer Please review.

    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
    • dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops
  • 16 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
    • dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
    • dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

utle
utle previously approved these changes Dec 27, 2024
@jhanders34
Copy link
Member

#30502 / #30625 were merged in now so I believe this can be closed.

@mshah0722 mshah0722 closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants