Add fixture light4me/venom-par-7x30
#4570
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
added
new-fixture
Export files validity(Output of test script Test the exported files of selected fixtures against the plugins' export tests. ✔️ light4me / venom-par-7x30: d-light / attributes-correctness
✔️ light4me / venom-par-7x30: dmxcontrol3 / channel-numbers
❌ light4me / venom-par-7x30: dragonframe / json-schema-conformity
✔️ light4me / venom-par-7x30: millumin / json-schema-conformity
✔️ light4me / venom-par-7x30: qlcplus_4.12.2 / fixture-tool-validation
✔️ light4me / venom-par-7x30: qlcplus_4.12.2 / xsd-schema-conformity
|
kengruven
reviewed
Jan 20, 2025
Comment on lines
+3
to
+4
| "name": "VENOM PAR 7X30", | ||
| "shortName": "VENOM 7X30", |
There was a problem hiding this comment.
Suggested change
| "name": "VENOM PAR 7X30", | |
| "shortName": "VENOM 7X30", | |
| "name": "Venom PAR 7x30", |
| "$schema": "https://raw.githubusercontent.com/OpenLightingProject/open-fixture-library/master/schemas/fixture.json", | ||
| "name": "VENOM PAR 7X30", | ||
| "shortName": "VENOM 7X30", | ||
| "categories": ["Dimmer", "Color Changer", "Strobe"], |
There was a problem hiding this comment.
Suggested change
| "categories": ["Dimmer", "Color Changer", "Strobe"], | |
| "categories": ["Color Changer"], |
| "physical": { | ||
| "dimensions": [230, 230, 150], | ||
| "weight": 2.2, | ||
| "power": 180, |
There was a problem hiding this comment.
Suggested change
| "power": 180, | |
| "power": 210, |
Comment on lines
+28
to
+36
| "wheels": { | ||
| "Static color selection": { | ||
| "slots": [ | ||
| { | ||
| "type": "Color" | ||
| } | ||
| ] | ||
| } | ||
| }, |
There was a problem hiding this comment.
Suggested change
| "wheels": { | |
| "Static color selection": { | |
| "slots": [ | |
| { | |
| "type": "Color" | |
| } | |
| ] | |
| } | |
| }, |
| }, | ||
| { | ||
| "dmxRange": [5, 255], | ||
| "type": "StrobeSpeed", |
There was a problem hiding this comment.
Suggested change
| "type": "StrobeSpeed", | |
| "type": "ShutterStrobe", | |
| "shutterEffect": "Strobe", |
Comment on lines
+147
to
+148
| "type": "Generic", | ||
| "comment": "Red + Green" |
There was a problem hiding this comment.
Suggested change
| "type": "Generic", | |
| "comment": "Red + Green" | |
| "type": "ColorPreset", | |
| "comment": "Red + Green", | |
| "colors": ["#ffff00"] |
Comment on lines
+152
to
+153
| "type": "Generic", | ||
| "comment": "Red + Blue" |
There was a problem hiding this comment.
Suggested change
| "type": "Generic", | |
| "comment": "Red + Blue" | |
| "type": "ColorPreset", | |
| "comment": "Red + Blue", | |
| "colors": ["#ff00ff"] |
Comment on lines
+157
to
+158
| "type": "Generic", | ||
| "comment": "Green + Blue" |
There was a problem hiding this comment.
Suggested change
| "type": "Generic", | |
| "comment": "Green + Blue" | |
| "type": "ColorPreset", | |
| "comment": "Green + Blue", | |
| "colors": ["#00ffff"] |
| }, | ||
| { | ||
| "dmxRange": [224, 255], | ||
| "type": "Generic", |
There was a problem hiding this comment.
Suggested change
| "type": "Generic", | |
| "type": "ColorPreset", |
Comment on lines
+90
to
+119
| { | ||
| "dmxRange": [0, 50], | ||
| "type": "Generic", | ||
| "comment": "Control via channels CH1 - CH6" | ||
| }, | ||
| { | ||
| "dmxRange": [51, 100], | ||
| "type": "Generic", | ||
| "comment": "Static color, add 8CH for color selection" | ||
| }, | ||
| { | ||
| "dmxRange": [101, 150], | ||
| "type": "Generic", | ||
| "comment": "Color Jump mode" | ||
| }, | ||
| { | ||
| "dmxRange": [151, 200], | ||
| "type": "Generic", | ||
| "comment": "Color Gradient mode" | ||
| }, | ||
| { | ||
| "dmxRange": [201, 250], | ||
| "type": "Generic", | ||
| "comment": "Color Pulse mode" | ||
| }, | ||
| { | ||
| "dmxRange": [251, 255], | ||
| "type": "Generic", | ||
| "comment": "Sound mode" | ||
| } |
There was a problem hiding this comment.
Suggested change
| { | |
| "dmxRange": [0, 50], | |
| "type": "Generic", | |
| "comment": "Control via channels CH1 - CH6" | |
| }, | |
| { | |
| "dmxRange": [51, 100], | |
| "type": "Generic", | |
| "comment": "Static color, add 8CH for color selection" | |
| }, | |
| { | |
| "dmxRange": [101, 150], | |
| "type": "Generic", | |
| "comment": "Color Jump mode" | |
| }, | |
| { | |
| "dmxRange": [151, 200], | |
| "type": "Generic", | |
| "comment": "Color Gradient mode" | |
| }, | |
| { | |
| "dmxRange": [201, 250], | |
| "type": "Generic", | |
| "comment": "Color Pulse mode" | |
| }, | |
| { | |
| "dmxRange": [251, 255], | |
| "type": "Generic", | |
| "comment": "Sound mode" | |
| } | |
| { | |
| "dmxRange": [0, 50], | |
| "type": "NoFunction", | |
| "switchChannels": { | |
| "Effect speed / Static color selection": "Effect speed" | |
| }, | |
| "comment": "Control via channels CH1 - CH6", | |
| "helpWanted": "Does channel 8 do anything here?" | |
| }, | |
| { | |
| "dmxRange": [51, 100], | |
| "type": "NoFunction", | |
| "switchChannels": { | |
| "Effect speed / Static color selection": "Static color selection" | |
| } | |
| "comment": "Static color, add 8CH for color selection" | |
| }, | |
| { | |
| "dmxRange": [101, 150], | |
| "type": "Effect", | |
| "effectPreset": "ColorJump", | |
| "switchChannels": { | |
| "Effect speed / Static color selection": "Effect speed" | |
| } | |
| }, | |
| { | |
| "dmxRange": [151, 200], | |
| "type": "Effect", | |
| "effectPreset": "ColorFade", | |
| "switchChannels": { | |
| "Effect speed / Static color selection": "Effect speed" | |
| } | |
| }, | |
| { | |
| "dmxRange": [201, 250], | |
| "type": "Effect", | |
| "effectName": "Color Pulse mode", | |
| "switchChannels": { | |
| "Effect speed / Static color selection": "Effect speed" | |
| } | |
| }, | |
| { | |
| "dmxRange": [251, 255], | |
| "type": "Effect", | |
| "effectName": "Sound mode", | |
| "soundControlled": true, | |
| "switchChannels": { | |
| "Effect speed / Static color selection": "Effect speed" | |
| }, | |
| "helpWanted": "Does channel 8 do anything here?" | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
light4me/venom-par-7x30Fixture warnings / errors
Thank you Karel z Hor!