Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Sync Kinesis partitionKey format with Kafka implementation #2620

Conversation

dolfinus
Copy link
Contributor

Problem

See #2616 (comment)

Solution

One-line summary:

Change format of Kinesis partitionKey from {jobNamespace}:{jobName} to run:{jobNamespace}/{jobName}, to match Kafka transport implementation.

Checklist

  • You've signed-off your work
  • Your pull request title follows our guidelines
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
  • You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
  • You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

@pawel-big-lebowski
Copy link
Collaborator

@dolfinus could you resolve the conflict so we can merge it?

@dolfinus dolfinus force-pushed the feature/kinesis-partition-key-format branch from bbe5c8a to 9e9bc13 Compare April 19, 2024 07:50
@pawel-big-lebowski pawel-big-lebowski merged commit 27aacd8 into OpenLineage:main Apr 19, 2024
43 checks passed
@dolfinus dolfinus deleted the feature/kinesis-partition-key-format branch April 19, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:client/java openlineage-java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants