Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : DREMIO to supported dbt profile types #2674

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix : DREMIO to supported dbt profile types #2674

merged 1 commit into from
May 7, 2024

Conversation

surisimran
Copy link
Contributor

Problem

The dbt provider has a hardcoded set of supported dbt connection types FIX. This adds dremio to the list.

Closes: #2668
Reference Review : #2671

Solution

Add an if clause for DREMIO to DbtArtifactProcessor.extract_namespace for profile (having software_host)

  • Your change modifies the core OpenLineage model
  • Your change modifies one or more OpenLineage facets

One-line summary:

Add support for dbt-dremio, solving #2668 and reference review #2671

Checklist

  • You've signed-off your work
  • Your pull request title follows our guidelines
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
  • You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
  • You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

@boring-cyborg boring-cyborg bot added the area:integration/common openlineage-integration-common label May 7, 2024
@surisimran
Copy link
Contributor Author

@JDarDagran , @mobuchowski
Fixed DREMIO to supported dbt profile types PR #2671 as per the review comments.
Please re-review and approve this PR

@JDarDagran JDarDagran merged commit 379e9d3 into OpenLineage:main May 7, 2024
30 checks passed
@kacpermuda
Copy link
Contributor

Thanks @surisimran for the contribution. FYI, there is no need to close and re-open the PR whenever the CI fails or there is some other problem, you can easily push to the same branch and CI will re-launch, comments will still be here etc. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:integration/common openlineage-integration-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INTEGRATION] dbt-dremio
4 participants