Skip to content

Commit

Permalink
Deprecation errors are not suppressed anymore (#3102)
Browse files Browse the repository at this point in the history
  • Loading branch information
fballiano authored Mar 20, 2023
1 parent 951fdb8 commit db68c32
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 20 deletions.
14 changes: 3 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ Most important changes will be listed here, all other changes since `19.4.0` can
- search for "NULL" in backend grids ([#1203](https://github.com/OpenMage/magento-lts/pull/1203))
- removed `lib/flex` containing unused ActionScript "file uploader" files ([#2271](https://github.com/OpenMage/magento-lts/pull/2271))
- Mage_Catalog_Model_Resource_Abstract::getAttributeRawValue() now returns `'0'` instead of `false` if the value stored in the database is `0` ([#572](https://github.com/OpenMage/magento-lts/pull/572))
- PHP extension `intl` is required
- Deprecation errors are not suppressed anymore
- removed modules:
- `Mage_Backup` ([#2811](https://github.com/OpenMage/magento-lts/pull/2811))
- `Mage_Compiler`
Expand All @@ -192,10 +194,6 @@ _If you rely on those modules you can reinstall them with composer:_
- `Mage_PageCache`: `composer require openmage/module-mage-pagecache`
- `Legacy frontend themes`: `composer require openmage/legacy-frontend-themes`

### Between OpenMage 19.4.18 / 20.0.16 and 19.4.19 / 20.0.17

- PHP extension `intl` is required

### Between OpenMage 19.x and 20.x

Do not use 20.x.x if you need IE support.
Expand Down Expand Up @@ -305,13 +303,7 @@ grep -rn 'urn:Magento' --include \*.xml
- Open your site in browser
```bash
ddev launch
```

## Development with PHP 8.1+

Deprecation errors are supressed by default.

If you want to work on PHP 8.1+ support, set environment variable `DEV_PHP_STRICT` to `1`, to show all errors.
```

## PhpStorm Factory Helper

Expand Down
9 changes: 0 additions & 9 deletions app/code/core/Mage/Core/functions.php
Original file line number Diff line number Diff line change
Expand Up @@ -123,15 +123,6 @@ function mageCoreErrorHandler($errno, $errstr, $errfile, $errline)
return false;
}

// Suppress deprecation warnings on PHP 7.x
// set environment variable DEV_PHP_STRICT to 1 will show E_DEPRECATED errors
if ((!isset($_ENV['DEV_PHP_STRICT']) || $_ENV['DEV_PHP_STRICT'] != '1')
&& $errno == E_DEPRECATED
&& version_compare(PHP_VERSION, '7.0.0', '>=')
) {
return true;
}

// PEAR specific message handling
if (stripos($errfile . $errstr, 'pear') !== false) {
// ignore strict and deprecated notices
Expand Down

0 comments on commit db68c32

Please sign in to comment.