Added methods to support "error state" for cron schedule (#3310)

* Check if cron is on error * Add method getIsError * added return type as suggested by @sreichel --------- Co-authored-by: Fabrizio Balliano <[email protected]>
OpenMage · Jun 22, 2023 · ea2fa76 · ea2fa76
1 parent 0992d8c
commit ea2fa76
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/app/code/core/Mage/Cron/Model/Observer.php b/app/code/core/Mage/Cron/Model/Observer.php
@@ -326,6 +326,11 @@ protected function _processJob($schedule, $jobConfig, $isAlways = false)
             $schedule->setStatus($errorStatus)
                 ->setMessages($e->__toString());
         }
+
+        if ($schedule->getIsError()) {
+            $schedule->setStatus(Mage_Cron_Model_Schedule::STATUS_ERROR);
+        }
+
         $schedule->save();
 
         return $this;

diff --git a/app/code/core/Mage/Cron/Model/Schedule.php b/app/code/core/Mage/Cron/Model/Schedule.php
@@ -22,6 +22,7 @@
  * @method Mage_Cron_Model_Resource_Schedule _getResource()
  * @method Mage_Cron_Model_Resource_Schedule getResource()
  * @method Mage_Cron_Model_Resource_Schedule_Collection getCollection()
+ * @method $this setIsError(bool $value)
  * @method string getJobCode()
  * @method $this setJobCode(string $value)
  * @method string getStatus()
@@ -53,6 +54,14 @@ public function _construct()
         $this->_init('cron/schedule');
     }
 
+    /**
+     * @return bool
+     */
+    public function getIsError(): bool
+    {
+        return !empty($this->getData('is_error'));
+    }
+
     /**
      * @param string $expr
      * @return $this