-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow quoted-string email format. #378
Comments
This one?
+1 to remove. |
colinmollenhour
added a commit
to colinmollenhour/magento-lts
that referenced
this issue
Jan 17, 2018
Created PR #432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm all for full RFC compliance and support, but in this case I think it is worth deviating from. The Zend_Validate_EmailAddress supports quoted-string style email addresses which I have never seen anyone use for legitimate purposes. Already this quoted-string format is not allowed by frontend validation so legitimate users can't use it anyway. The only use it has is to try to inject scripts into people's databases/pages and for this reason I think it should be dis-allowed.
Specifically, this block here could be disabled/removed: https://github.com/OpenMage/magento-lts/blob/1.9.3.x/lib/Zend/Validate/EmailAddress.php#L426
The text was updated successfully, but these errors were encountered: