Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for currency symbol not saved with fatal PHP error #1319

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Fix for currency symbol not saved with fatal PHP error #1319

merged 1 commit into from
Nov 24, 2020

Conversation

jouriy
Copy link
Contributor

@jouriy jouriy commented Nov 23, 2020 •
edited
Loading

Description (*)

Fix for Currency symbol not saved with fatal PHP error
Replace Mage::getSingleton('connect/session') with Mage::getSingleton('adminhtml/session') in CurrencysymbolController

Fixed Issues (if relevant)

  1. Fixes Currency symbol not saved with fatal PHP error #1318

Manual testing scenarios (*)

  1. Login to backend and navigate to System > Manage Currency > Symbols
  2. Click on Save Currency Symbols button
  3. Ensure that currency symbol is saved and green success "Custom currency symbols were applied successfully." notice is shown.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: CurrencySymbol Relates to Mage_CurrencySymbol label Nov 23, 2020
kiatng
kiatng approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mage_Connect was removed in PR #952.

kkrieger85
kkrieger85 approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@kkrieger85 kkrieger85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkrieger85 kkrieger85 merged commit df99362 into OpenMage:1.9.4.x Nov 24, 2020
@sreichel sreichel added the bug label Dec 27, 2020
@sreichel sreichel added this to the Release 19.4.9 / 20.0.5 milestone Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshua-bn joshua-bn joshua-bn approved these changes

@kkrieger85 kkrieger85 kkrieger85 approved these changes

@kiatng kiatng kiatng approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
bug Component: CurrencySymbol Relates to Mage_CurrencySymbol
Projects
None yet
Milestone
Release 19.4.9 / 20.0.5
Development

Successfully merging this pull request may close these issues.

Currency symbol not saved with fatal PHP error
6 participants
@jouriy @colinmollenhour @kiatng @kkrieger85 @joshua-bn @sreichel