Fixed Zend Lib Amf Deprecated Notice #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urly braces is deprecated
|
@daim2k5 I think your PR are better suited with 20.x as branch to commit in. |
|
Support of new PHP Versions (in the sense of not failing or complaining) is part of the LTS version "19.", so 1.9.4.x is the correct branch |
|
Depends on the PHP Version, doesn't it? Newer PHP Version would/could lead to BC. |
|
they generally should not, if they do, this would be a bug we need to handle. |
kiatng
approved these changes
Dec 13, 2020
|
@kkrieger85 i asked @Flyingmana before i created the PR to the "1.9.4.x" Branch :-) |
|
Perfect.
For me, it's unclear which changes should be PR to which base branch
Damian Luszczymak <[email protected]> schrieb am So., 13. Dez. 2020,
09:41:
… @kkrieger85 <https://github.com/kkrieger85> i asked @Flyingmana
<https://github.com/Flyingmana> before i created the PR to the "1.9.4.x"
Branch :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1347 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABB24Q5NFFY4W7OIPVAPQL3SUR43BANCNFSM4UYUULXQ>
.
|
Flyingmana
approved these changes
Dec 14, 2020
sreichel
approved these changes
Dec 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
bugfix(zend) Deprecated: Array and string offset access syntax with curly braces is deprecated
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)