Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(BC) Remove js index file #1622

Merged
merged 1 commit into from
Jun 7, 2022
Merged

(BC) Remove js index file #1622

merged 1 commit into from
Jun 7, 2022

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented May 16, 2021 •
edited
Loading

Description

This PR require #1618 because it remove the last usage of:

<script type="text/javascript" src="<?php echo $this->getJsUrl() ?>index.php/x.js?f=prototype/prototype.js,...">

I think it's so outdated.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the JavaScript Relates to js/* label May 16, 2021
@luigifab luigifab changed the base branch from 1.9.4.x to 20.0 May 16, 2021 04:58
@luigifab luigifab changed the base branch from 20.0 to 1.9.4.x May 16, 2021 04:59
@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogSearch Relates to Mage_CatalogSearch Component: Checkout Relates to Mage_Checkout Component: Cm/RedisSession Relates to Cm_RedisSession Component: Cms Relates to Mage_Cms Component: Contacts Relates to Mage_Contacts Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Index Relates to Mage_Index Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Newsletter Relates to Mage_Newsletter Component: Page Relates to Mage_Page Component: Payment Relates to Mage_Payment labels May 16, 2021
@luigifab luigifab changed the base branch from 1.9.4.x to 20.0 May 16, 2021 07:04
@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Persistant Relates to Mage_Persistant Component: Reports Relates to Mage_Reports Component: Review Relates to Mage_Review Component: Rss Relates to Mage_Rss Component: Sales Relates to Mage_Sales Component: Sendfriend Relates to Mage_Sendfriend Component: Shipping Relates to Mage_Shipping labels May 16, 2021
@github-actions github-actions bot removed Component: Bundle Relates to Mage_Bundle Component: Tax Relates to Mage_Tax Component: lib/* Relates to lib/* Component: Core Relates to Mage_Core Component: Cm/RedisSession Relates to Cm_RedisSession Component: Persistant Relates to Mage_Persistant Component: CatalogSearch Relates to Mage_CatalogSearch labels Jun 6, 2021
@jouriy
Copy link
Contributor

jouriy commented Jun 6, 2021

Would love to see it in 1.9.4.x as well, removing it will allow to have whole js/ static with legit "php_flag engine 0" in js/.htaccess and default nginx config serving js/ as static files.

@luigifab
Copy link
Contributor Author

luigifab commented Sep 4, 2021

@jouriy this PR is a BC for people that use this old functionality, so I changed to 20.0.

@jouriy
Copy link
Contributor

jouriy commented Sep 5, 2021

@luigifab, great, I can keep it on my own, so no problem

@justinbeaty justinbeaty mentioned this pull request May 14, 2022
Merged
3 tasks
@luigifab luigifab removed the Component: PayPal Relates to Mage_Paypal label May 20, 2022
@fballiano fballiano merged commit f93c9e0 into OpenMage:20.0 Jun 7, 2022
@luigifab luigifab deleted the drop-js-index branch June 7, 2022 19:40
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  +1  7 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit f93c9e0. ± Comparison against base commit ff6189a.

@addison74 addison74 mentioned this pull request Jul 7, 2022
Closed
akunzai added a commit to akunzai/MageBridgeCore that referenced this pull request Nov 25, 2023
@akunzai
Skip to check permissions for js/index.php
4affec6 
- OpenMage/magento-lts#1622
akunzai added a commit to akunzai/MageBridgeCore that referenced this pull request Nov 25, 2023
@akunzai
Skip to check permissions for js/index.php
d631140 
- OpenMage/magento-lts#1622
akunzai added a commit to akunzai/MageBridgeCore that referenced this pull request Nov 26, 2023
@akunzai
Skip to check permissions for js/index.php
608ad28 
- OpenMage/magento-lts#1622
akunzai added a commit to akunzai/MageBridgeCore that referenced this pull request Nov 26, 2023
@akunzai
Skip to check permissions for js/index.php
bc29339 
- OpenMage/magento-lts#1622
akunzai added a commit to akunzai/MageBridgeCore that referenced this pull request Nov 26, 2023
@akunzai
Skip to check permissions for js/index.php
61ec9b9 
- OpenMage/magento-lts#1622
akunzai added a commit to akunzai/MageBridgeCore that referenced this pull request Nov 26, 2023
@akunzai
Skip to check permissions for js/index.php
a4f7982 
- OpenMage/magento-lts#1622
akunzai added a commit to akunzai/MageBridgeCore that referenced this pull request Nov 26, 2023
@akunzai
Skip to check permissions for js/index.php
e13963b 
- OpenMage/magento-lts#1622
akunzai added a commit to akunzai/MageBridgeCore that referenced this pull request Nov 26, 2023
@akunzai
Skip to check permissions for js/index.php
d145054 
- OpenMage/magento-lts#1622
akunzai added a commit to akunzai/MageBridgeCore that referenced this pull request Nov 26, 2023
@akunzai
Skip to check permissions for js/index.php
542ccb4 
- OpenMage/magento-lts#1622
akunzai added a commit to akunzai/MageBridgeCore that referenced this pull request Nov 26, 2023
@akunzai
Skip to check permissions for js/index.php
201f418 
- OpenMage/magento-lts#1622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmewes tmewes tmewes approved these changes

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
JavaScript Relates to js/*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luigifab @jouriy @fballiano @addison74 @tmewes