Dashboard - Top 5 Search Terms link issue #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dashboard - Top 5 Search Terms link issue
github-actions
bot
added
the
Component: CatalogSearch
This PR solves the isssue reported here
…t-alt-tag Recently Viewed Products block - No alt tag value
github-actions
bot
added
Component: Reports
|
@addison74 be careful with the source branches for the PRs, this one contained also the changes from #1920 I still merged it, as we already merged the other one |
|
I know that but I did not want to close this PR. I will try to avoid such mistake in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go to Dashboard page in Backend and take a look to the following blocks Last 5 Search Terms and Top 5 Search Terms.
Now place your mouse pointer over a search term in Last 5 Search Terms list and take a look to the URL. Here is the link in my case https://www.mydomain.tld/index.php/admin/catalog_search/edit/id/41/key/5874688c27ec9781d42bacfd92420f0e/
Now place your mouse pointer over a search term in Top 5 Search Terms list and take a look to the URL. Here is the link in my case https://www.mydomain.tld/index.php/admin/catalog_search/edit/key/5874688c27ec9781d42bacfd92420f0e/
The last link has an issue. Comparing with the first one which redirects correctly to edit the search term this one is opening the page to create a new search query not editing the search term. This is happening because the link has missing two parameters id and id_number between /edit/ ... /key/
This PR fixes this issues and closes issue #1310 .