Replace deprecated global now() calls with Varien_Date::now()

[Sdfendor]

Description (*)

Global function now() and static method Varien_Date::now() are equivalent. #1991 accommodated that by deprecating the global function. This PR does two things:

• Replacing all calls to now() with Varien_Date::now()
• Where possible a variable is used instead of multiple immediately subsequent calls of the method.

Additionally there is a reformat for an if-conditional in which the method is used.

Related Pull Requests

#1991

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[fballiano]

LGTM

[addison74]

The PR idea is fine with one condition, to have consistency regarding the source code. I notice that either a $now variable or Varien_Date :: now() are used. My proposal is to give up declaring the $now variable everywhere.

[Sdfendor]

@addison74 $now is used only in cases where the method is called multiple times immediately one after another (e.g. to fill a 'created_at' field and a 'updated_at' field in the same array to be saved to DB). That made no sense to me.
Or take for example:

Why should (in case the $object has no id and is freshly created) Varien_Date::now() be called two times? The result will be the same anyways because the datetime format used doesn't include milliseconds.

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit be12715. ± Comparison against base commit 412bee0.