Fixed faulty media gallery label/description management for mutistore projects

[fballiano]

We're talking about the "images tab" of the product management page:

The complete problem explanation and testing scenario is explained in issue #685

It wasn't easy to fix, I worked on it quite some hours. Hope I didn't miss anything.

Fixed Issues

1. Fixes Image label per store view does not work as expected #685

[fballiano]

Could somebody test this? It's a proper bug we're having since the beginning of time.

[addison74]

There are a lot of check failures in the "Files changed' section (at the end). Could you please investigate if they are real warnings?

[fballiano]

I'll check it out asap!

[fballiano]

actually those notice are in the "Unchanged files with check annotations", those files weren't changed in this PR so I wouldn't do anything about those notices.

[fballiano]

@azambon I'd love your comment on this

[azambon]

Sory for the massive delay, I completely forgot about this!

I did try to reproduce the same scenario that I described in the issue, but I don't think that this PR actually solves it.
As far as I could see, this PR adds the possibility of marking the whole "label" and "position" columns as "use default" in non-default store views.
Even ignoring the fact that someone may want to specify "use default" only for the labels and positions of some images, the bug that I reported is about both a situation where the labels must implement the "use default" behavior, but also about a case when the labels must be different (when I said to set the label "CCC" in the non-default store view). And in both cases I still see the wrong values in the frontend (yes, I disabled all caching, just to be sure).

So, unless I'm missing something, this does not seem to fix issue #685 . At least not yet.

As I see it, there are a couple of things left to solve:

• fix the values that are saved for the image_label, small_image_label and thumbnail_label attributes for non-default store views. That should fix the frontend and all other places that use those attributes;
• (optionally) move the "use default" checkboxes to be per-image for the "label" and "position" columns, instead of being global as they were implemented in this PR.

[fballiano]

Hi @azambon and thanks for the test,

• I'm pretty sure the values are saved correctly on the DB, if you switch storeview in the backend you should see the values you entered per every store view
• I think I didn't check the frontend at all, so that could need another fix
• I've to say I wouldn't put the checkbox "per image", that would be much harder, maybe it could be done in a second PR but to me at least it should work with "all images"

[fballiano]

@azambon I tested the frotend and the image labels seem to be correct to me, both in default and the single store view, the labels changes and are the same I see in the backend. This is tested on RWD theme.

[azambon]

I performed the scenario that I described in the issue once more, taking some screenshots.

As you can see, when I uncheck the new "use default" checkbox that you added in order to set the label CCC for the non-default store view, the data is saved correctly in the catalog_product_entity_media_gallery_value table, but the attributes in catalog_product_entity_varchar are not updated correctly.
And, as you can see, in the frontend of the non-default store view I still see the wrong value.

This is with a fresh installation of OpenMage with the default theme, no customizations at all and all caches disabled.
If you use a frontend theme that does not use the image_label, small_image_label and thumbnail_label product attributes and uses the media gallery directly, then yes, the frontend would work fine too. But those attributes would still contain a wrong value, and anything that used them would get the wrong data.

[fballiano]

sorry for the stupid question, did you reindex/recache? cause I checked it yesterday and I see the right things in frontend, if I didn't understand something wrong :-\

[azambon]

All caches are disabled and I did reindex (even though reindexing should not affect the values in the catalog_product_entity_* tables, only in the catalog_product_flat_* tables, if flat tables are enabled).

[fballiano]

I've flat disabled, just in case

[fballiano]

I'll post a few screenshots to check that i'm not drunk :-D

backend for default:

backend for non default

frontend for default

and frontend for the non default storeview

[empiricompany]

i've tested this PR with this value from backend:

eav_attribute

catalog_product_entity_varchar (not updated)

catalog_product_entity_media_gallery (value_id reference for catalog_product_entity_media_gallery_value )

catalog_product_entity_media_gallery_value (correctly updated)

catalog_product_flat_1 (not updated no index requested -default store)

catalog_product_flat_2 (not updated no index requested - store english)

catalog_product_flat_3 (not updated no index requested - store french)

result in frontend title is always from admin value default, for exampla french view:

[empiricompany]

i've fixed the reported issues
please try this PR: https://github.com/fballiano/openmage/pull/21

correct eav values table
catalog_product_entity_varchar

correct flat per store tables
catalog_product_flat_2

[fballiano]

I've integrated @empiricompany latest patch to this PR and retested it, it seems to be working correctly to me.

[kyrena]

Tested, seems working.

From #685, this does not work: "In the admin add another image to the product with the label DDD in the default store view. Mark it as the default base image, small image and thumbnail and set its label to DDD" I must save again the product at store view level to have the right label.

Another thing, perhaps already the case, not sure, when I upload a new image, if I select it as default images, when I save the product, I must select again it as default images and save again, else the selection is lost.

[fballiano]

true, this needs to be addressed:

• when you upload a new image, the first time you save the product, the fact that you selected the image as base/small/thumb isn't not saved

[fballiano]

I've fixed the last remaining point, it was only 1 line that was removed (and now reintroduced).

Since there were already 2 gray check I'll merge this, it's an important bugfix too long overdue (and a huge amount of work to develop it).