-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite autoloader #2734
Rewrite autoloader #2734
Conversation
Please add more info and context around this change.
|
@@ -13,10 +13,3 @@ | |||
); | |||
} | |||
} | |||
|
|||
spl_autoload_register(function($className) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file should get removed by #2411
Original version is: The simplified version used in this PR (all tests bellow with Blackfire with it): First, with Second, with Third, with The difference between |
Today I realize that perhaps the replace of the space is not necessary? Not tested. |
lib/phpseclib is no longer with us :-) |
this has a conflict now, I'll move it to draft |
What speaks against first finishing/merging #2300 to fix the bug, and then do the performance improvement separately? |
Description
This PR fix #1780 and replace #1817 and #2300.
It's created from @woutersamaey, @Asfolny, @Flyingmana, and me ideas.
There is a tiny breaking change:
for example with
Ext4mage/Orders2csvpro
, there are:<source_model>ext4mage_orders2csvpro_model_source_creditmemofiles</source_model>
This does not work any more, because
ucwords
is removed in this PR.I checked with Blackfire, this is a performance regression (see comment bellow).
But from ~5 ms to ~10 ms.
I didn't tested with #1969.
Contribution checklist