-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version bump #2835
Version bump #2835
Conversation
Does upper/lower-case matter? |
... but ... we have an error that sould be fixed. If its okay i'd remove latest release from packagist.org. |
I don't think so, I used lowercase since it was already in the sample (comment next to the "alpha/beta/rc" like) |
but how can we fix that anyway now? |
You are doing the releases. Is it much work to make that hotfix release? We could fix this bug w/o enforce to update to Zend-changes. |
@sreichel in this case it's pretty easy, I've already created branch https://github.com/OpenMage/magento-lts/tree/19.4.21 with just 2 commits. they're pretty basic so everything should be ok. can you check it out a second and then I'll release? also, it's a v19 hotfix only because v20 doesn't have the bug with #2793 |
Perfect. |
be very very very careful with removing releases, this is going to break anyone who uses this in their composer.json or composer.lock. |
We’ll not remove anything don’t worry |
Thanks. This is why i asked for. Is there another propper way to avoid installing "bugged" releases? Something like a required extension that cant we installed with certain releases?
I'd not re-add it. If its bugged it should be not available to install. However ... not going to touch this. |
Tomorrow morning I’ll release the new v19 and there will be no problem anymore 😉 |
19.4.21 is released, I was afraid of the process but at the end of the day it was pretty easy and I should have done it ealier.. it's done anyway now. |
regarding the original question, can you link this very important stuff? But I wonder what it is, that requires the minor version bump, especially for the 19. release |
it's the drop of CM modules and ZF1 moving them to composer |
linkedin the PRs in the description. I think the bump should be minor, not your patch version |
I see, that surely is a good reason for a minor version bump. And also a good reason for RC Tagging. |
Since we just merged pretty important stuff, but at the same time we need more testing-time, what about a next version like 20.1.0-rc1 and 19.5.0-rc1?
Related PRs