Ensure count() is not called on a string #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: lib/Varien
Flyingmana
reviewed
Jan 3, 2023
kiatng
reviewed
Jan 5, 2023
|
Why not simply this? if (preg_match('/^(\w+)\[(\w+)\]$/', $fileId, $file)) {If the statement is true then |
kiatng
reviewed
Jan 6, 2023
Instead of checking the results of preg_match by counting the length of the string, simply check for the success value. This prevents PHP 8.1 deprecation warnings.
mattdavenport
force-pushed
the
fix/php8.1/upload-countable-bug
branch
from
31f75b0 to
3ec2e39
Compare
|
Code updated. Thanks everyone for the feedback! |
elidrissidev
approved these changes
Jan 6, 2023
addison74
approved these changes
Jan 6, 2023
fballiano
pushed a commit
that referenced
this pull request
Jan 6, 2023
Instead of checking the results of preg_match by counting the length of the string, simply check for the success value. This prevents PHP 8.1 deprecation warnings.
|
cherry-picked to 20.0 since there were no conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the PHP 8.1 deprecation warning on
setUploadFileIdby checking the existence ofpreg_matchvalues usingisset()rather thancount()which is now deprecated for string types.