Resolve getPasswordTimestamp join issues #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve backend type being incorrect and not correctly joining to the entity values correctly.
alexkirsch
changed the title
kiatng
approved these changes
Feb 3, 2023
addison74
approved these changes
Feb 3, 2023
elidrissidev
approved these changes
Feb 3, 2023
fballiano
pushed a commit
that referenced
this pull request
Feb 3, 2023
…3010) Resolve backend type being incorrect and not correctly joining to the entity values correctly.
|
cherrypicked to v20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve backend type being incorrect and not correctly joining to the entity values correctly.
Description (*)
getPasswordTimestamp() is joining to the incorrect table and not properly joining in on the password_created_at int value table. This results in always using the customer_entity table created_at timestamp.. which if that is the intent we should remove the join or properly join.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)