Remove status filter from Product Collection in CatalogSearch Layer

[elidrissidev]

Description (*)

A followup to #2662 which removed the status filter from Product Collection in Catalog Layer to fix the issue discussed in #2603 (comment).

This issue could be fixed by #2660, but this change is just to keep the consistency between Catalog and CatalogSearch Layers.

Related Pull Requests

• See Fixes #2658 #2662
• See Fixed Mage_Catalog_Model_Product_Status::addSaleableFilterToCollection() does nothing #2603

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[fballiano]

question, are we loosing the status filter completely or it was duplicate so this way we're avoiding the duplicate?

[elidrissidev]

question, are we loosing the status filter completely or it was duplicate so this way we're avoiding the duplicate?

We're avoiding the duplicate only when flat tables are enabled, else the filter is never added to the collection.

[elidrissidev]

An important step to reproduce this issue is to make sure price attribute has "Use In Search Results Layered Navigation" value set to "Yes", otherwise this issue will not occur.

[fballiano]

but we should have the status filter if flat is not enabled no?

[elidrissidev]

It wasn't there before, and it was also removed from the Catalog view, so Idk...

[fballiano]

I thought I added the filter on status, cause disabled product should never be visible on frotend, and there was the method for that but the method was empty... I don't know...

[fballiano]

merged and v20ed