Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cast store config (checkout/cart/delete_quote_after) to int to avoid unsupported operand types php error #3065

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

darinda
Copy link
Contributor

@darinda darinda commented Mar 6, 2023

fixes #3064

Description (*)

Fixes #3064

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Unsupported operand types: string * int during cronjob 'sales_clean_quotes' #3064

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Sales Relates to Mage_Sales label Mar 6, 2023
@fballiano fballiano merged commit 4c61738 into OpenMage:20.0 Mar 6, 2023
@fballiano
Copy link
Contributor

auch, didn't notice this was on 20.0, I'll port it to 1.9.4.x

@elidrissidev
Copy link
Member

Wait why is this targeting 20.0 instead of 1.9.4.x

fballiano pushed a commit that referenced this pull request Mar 6, 2023
@fballiano
Copy link
Contributor

cherry picked it to 1.9.4.x

@darinda darinda deleted the patch-1 branch March 6, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Relates to Mage_Sales
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants