Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump PHPCSFixer to 3.15.1 + new fixes required #3106

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Bump PHPCSFixer to 3.15.1 + new fixes required #3106

merged 1 commit into from
Mar 20, 2023

Conversation

fballiano
Copy link
Contributor

Upgrading PHPCSFixer requires new fixes, this PR does both things

Related Pull Requests

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Admin Relates to Mage_Admin Component: Api2 Relates to Mage_Api2 Component: Catalog Relates to Mage_Catalog Component: Checkout Relates to Mage_Checkout Component: Dataflow Relates to Mage_Dataflow Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: Install Relates to Mage_Install Component: Paygate Relates to Mage_Paygate Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: PaypalUk Relates to Mage_PaypalUk Component: Review Relates to Mage_Review Component: Rule Relates to Mage_Rule Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Usa Relates to Mage_Usa composer Relates to composer.json labels Mar 20, 2023
@fballiano
Copy link
Contributor Author

The error on shown on src/shell/translations.php has already been solved in OpenMage/dev-translations@b80317b on the external repository, so this PR should already be ready.

@fballiano fballiano merged commit e2d5fed into OpenMage:1.9.4.x Mar 20, 2023
@fballiano fballiano deleted the phpcsupdate branch March 20, 2023 15:29
fballiano added a commit that referenced this pull request Mar 20, 2023
@fballiano
Bump PHPCSFixer to 3.15.1 + new fixes required (#3106)
cbfb537
@fballiano
Copy link
Contributor Author

merged and 20ed

@sreichel
Copy link
Contributor

Think dev-meta-package needs a version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@tmotyl tmotyl tmotyl approved these changes

Assignees
No one assigned
Labels
Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Catalog Relates to Mage_Catalog Component: Checkout Relates to Mage_Checkout Component: Dataflow Relates to Mage_Dataflow Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: Install Relates to Mage_Install Component: Paygate Relates to Mage_Paygate Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: PaypalUk Relates to Mage_PaypalUk Component: Review Relates to Mage_Review Component: Rule Relates to Mage_Rule Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Usa Relates to Mage_Usa composer Relates to composer.json
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fballiano @sreichel @tmotyl @addison74