Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used session_status() instead of $_SESSION in Mage_Core_Model_App #3145

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Used session_status() instead of $_SESSION in Mage_Core_Model_App #3145

merged 1 commit into from
Apr 5, 2023

Conversation

fballiano
Copy link
Contributor

As @tmotyl pointed out in #1592 (comment), quoting a comment by @Flyingmana it's better to use session_status() instead of $_SESSION.

Related Pull Requests

#1592

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Apr 5, 2023
@fballiano fballiano changed the title Used session_status instead of $_SESSION in Mage_Core_Model_App Used session_status() instead of $_SESSION in Mage_Core_Model_App Apr 5, 2023
@colinmollenhour colinmollenhour requested a review from tmotyl April 5, 2023 13:29
@fballiano fballiano merged commit c441b05 into OpenMage:main Apr 5, 2023
@fballiano fballiano deleted the sessionstatus branch April 5, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Relates to Mage_Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants