-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded TinyMCE to 6.7.0 #3220
Merged
Merged
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
3683b2d
First commit
fballiano c8fe0b5
First test converting the plugins
fballiano c87b2cd
Coverted part of the "variable" plugin
fballiano 138fda1
typo
fballiano a6ccefd
typo
fballiano 38e3527
renames plugin javascript files
fballiano 51f3fd9
something starts to work
fballiano 15c441e
Merge branch 'next' into tinymce6
fballiano 938aff0
upgraded to 6.4.2
fballiano 56908d5
Merge branch 'tinymce6' of github.com:fballiano/openmage into tinymce6
fballiano 828ef09
Fixed showing of plugin buttons
fballiano d43ca5c
removed tinyMceEditors hash from prototypejs
fballiano 318ff9f
close window image was ugly
fballiano 437b4da
file selector starts to work
fballiano 1a3aefb
Merge branch 'next' into tinymce6
fballiano 4dc6a93
fix for image upload when tinymce is not enabled
fballiano f584bfe
Merge branch 'tinymce6' of github.com:fballiano/openmage into tinymce6
fballiano c32e341
Merge branch 'next' into tinymce6
fballiano bdcf3ff
merged branch next
fballiano 1408f42
updated to 6.6.0
fballiano 1f98220
Merge branch 'next' into tinymce6
fballiano 1069158
encode/decode images directives
empiricompany 4cbdd82
updated to 6.6.1
fballiano 885a440
fix tinymce openmage variable and widget plugins and toolbar buttuns …
empiricompany fb7d6cb
Merge branch next
fballiano a7f3026
small cleanup
fballiano 218a0f1
small cleanup
fballiano 11d3133
removed custom css
fballiano 9b80c42
languages
fballiano 3d36452
languages
fballiano 750a10c
Tinymce skin config (#13)
empiricompany 18f4196
Fix prototype errors in chrome
empiricompany d2cdcca
set min-height (#15)
empiricompany d739ce3
fix tab changed on first load (#16)
empiricompany a5941cd
restore sysconfig original behavior (#17)
empiricompany 9b48a81
Fixed php82 bug
fballiano 1eb6a06
Merge branch 'next' into tinymce6
fballiano b4e4840
tinymce 6.6.2
fballiano 9247d52
add searchandreplace, embedded media, fontfamily (#18)
empiricompany 7737fec
removed openmage colors from variables/widgets icons
fballiano 2d1c88e
more similar formatting between these two files
fballiano fd09b2f
removed emoticons plugin, it is useless since our DB is not utf8mb4
fballiano 51f9491
Merge branch 'next' into tinymce6
fballiano 1658ac3
Merge branch 'next' into tinymce6
fballiano 5dd9689
Toolbar mode scrolling
fballiano 0bc43f4
New layout for menus and menubars
fballiano 37f44a2
Fixed widget label
fballiano 3a2ff97
Fixed "api.setActive is not a funcion"
fballiano 2cd4e0a
fix icon openmagevariable (#19)
empiricompany b832fc5
fix openmage plugins breaks help (#20)
empiricompany b8b39a3
Merge branch 'next' into tinymce6
fballiano f2b033a
TinyMCE 6.7.0
fballiano 4879f22
Merge branch 'next' into tinymce6
fballiano 58d063b
Merge branch 'next' into tinymce6
fballiano d3554e3
Merge branch 'next' into tinymce6
fballiano 1f2efb0
Merge branch 'next' into tinymce6
fballiano 288bd56
Merge branch 'next' into tinymce6
fballiano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
app/code/core/Mage/Adminhtml/Model/System/Config/Source/Cms/Wysiwyg/Skin.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
<?php | ||
/** | ||
* OpenMage | ||
* | ||
* This source file is subject to the Open Software License (OSL 3.0) | ||
* that is bundled with this package in the file LICENSE.txt. | ||
* It is also available at https://opensource.org/license/osl-3-0-php | ||
* | ||
* @category Mage | ||
* @package Mage_Adminhtml | ||
* @copyright Copyright (c) 2023 The OpenMage Contributors (https://www.openmage.org) | ||
* @license https://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0) | ||
*/ | ||
|
||
/** | ||
* Configuration source model for Wysiwyg skin | ||
* | ||
* @category Mage | ||
* @package Mage_Adminhtml | ||
*/ | ||
class Mage_Adminhtml_Model_System_Config_Source_Cms_Wysiwyg_Skin | ||
{ | ||
public function toOptionArray() | ||
{ | ||
return [ | ||
[ | ||
'value' => 'oxide', | ||
'label' => 'Oxide' | ||
], | ||
[ | ||
'value' => 'oxide-dark', | ||
'label' => 'Oxide Dark' | ||
], | ||
[ | ||
'value' => 'tinymce-5', | ||
'label' => 'Tinymce 5' | ||
], | ||
[ | ||
'value' => 'tinymce-5-dark', | ||
'label' => 'Tinymce 5 Dark' | ||
] | ||
]; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -200,6 +200,7 @@ | |
<cms> | ||
<wysiwyg> | ||
<enabled>enabled</enabled> | ||
<skin>oxide</skin> | ||
</wysiwyg> | ||
</cms> | ||
<system> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for type safety you should put $skipped as an empty array for the else case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in order not to drag this PR any longer I'd address it in a separate PR ASAP :-)