Reworked display of product alerts

[luigifab]

Description

Same but different :)

for configuration (system > configuration > catalog):

for product view:

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[kiatng]

I like it. But how about retaining the original labels, which are more explanatory?

[S0FTWEX]

@luigifab, I would like to keep the original labels too (they are more explanatory). Or better: you can move them to - this is the best solution.

[luigifab]

I'm going to update soon.

[addison74]

I agree with this PR in the following design

1. System > Configuration > Catalog

Comment: we are in the "Product Alerts" section, the two sub-sections must be "Price" and "Back in Stock", as obvious and simple as possible, without abusing of words. The rest of the phrases for every field remained the initial ones.

2. Product Edit page > Product Alerts tab

Comments: Initial phrases "Price alert subscription was saved." and "Stock notification was saved." they are devoid of logic. Those grids are just a listing of alerts, but they can't be edited to talk about a save.

I would rename them as "Price" and "Back in Stock" since we are in the "Price Alerts" tab, again without abusing of words. We can reformulate them "Price Notifications" and "Back in Stock Notifications" as well or "Price Subscriptions" and "Back in Stock Subscriptions".

[addison74]

A few personal opinions:

1 - I agree with the removal of the <div> container containing h4 - "Product Alerts" from the /product/tab/alert.phtml file. Its display is illogical and does not comply with the Backend presentation rules.

2 - I do not agree with the two <div> containers inserted in the /Tab/Alerts.php file. I would like to keep the presentation rules as before, if we make this change it would mean making changes in other places as well. Changing the titles is enough.

[fballiano]

tested again today, I like this PR but I too would remove the div around the table as @addison74 says.

[fballiano]

I've removed those divs around the table and IMHO it could be merged now :-)

[addison74]

@fballiano - Let's not rush because it's not finished yet. Please take a look here #3303 (comment). I made important observations after testing that must be implemented.