Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated copyright docblocks #3411

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Updated copyright docblocks #3411

merged 1 commit into from
Jul 27, 2023

Conversation

fballiano
Copy link
Contributor

This PR is created running the shell/update-copyright.php script for the main branch.

I think it's important that we update the docblock copyright data before the next stable release.

I'll create a separate PR for v19.

@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: CatalogInventory Relates to Mage_CatalogInventory Component: Checkout Relates to Mage_Checkout Component: AdminNotification Relates to Mage_AdminNotification Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: Adminhtml Relates to Mage_Adminhtml Mage.php Relates to app/Mage.php Component: Page Relates to Mage_Page Component: Api PageRelates to Mage_Api Component: Cron Relates to Mage_Cron Component: Captcha Relates to Mage_Captcha Component: Contacts Relates to Mage_Contacts Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: CatalogRule Relates to Mage_CatalogRule Component: Admin Relates to Mage_Admin Component: Payment Relates to Mage_Payment Component: Oauth Relates to Mage_Oauth Component: Index Relates to Mage_Index Component: Downloadable Relates to Mage_Downloadable Component: Bundle Relates to Mage_Bundle Component: CatalogIndex Relates to Mage_CatalogIndex Component: Api2 Relates to Mage_Api2 Component: Media Relates to Mage_Media Component: Log Relates to Mage_Log Component: ImportExport Relates to Mage_ImportExport labels Jul 26, 2023
@github-actions github-actions bot added Component: Directory Relates to Mage_Directory Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: CatalogSearch Relates to Mage_CatalogSearch Component: Authorizenet Relates to Mage_Authorizenet Component: Centinel Relates to Mage_Centinel Component: Dataflow Relates to Mage_Dataflow Component: GoogleAnalytics Relates to Mage_GoogleAnalytics Component: GoogleCheckout Relates to Mage_GoogleCheckout Component: Install Relates to Mage_Install Component: Paygate Relates to Mage_Paygate labels Jul 26, 2023
@fballiano fballiano merged commit 471b92d into OpenMage:main Jul 27, 2023
@fballiano fballiano deleted the copyrightupdate branch July 27, 2023 07:46
@pquerner
Copy link
Contributor

Is this something that really needs to happen nowadays?

Nice read: https://daniel.haxx.se/blog/2023/01/08/copyright-without-years/

@addison74
Copy link
Contributor

Opinions are divided. In addition, I always put the legal side first, which protects me from any problems that might arise later. In OpenMage we created a script that updates all the files that have been modified and it is not a big effort to achieve such PRs.

I would read this opinion too. Why keep the year? https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code.

seifer7 added a commit to seifer7/magento-lts that referenced this pull request Feb 1, 2024
@seifer7
Revert "Updated copyright docblocks (OpenMage#3411)"
bd6d68d 
This reverts commit 471b92d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@kiatng kiatng kiatng approved these changes

Assignees
No one assigned
Labels
Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: AdminNotification Relates to Mage_AdminNotification Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogSearch Relates to Mage_CatalogSearch Component: Centinel Relates to Mage_Centinel Component: Checkout Relates to Mage_Checkout Component: Cms Relates to Mage_Cms Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Contacts Relates to Mage_Contacts Component: Core Relates to Mage_Core Component: Cron Relates to Mage_Cron Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: GoogleAnalytics Relates to Mage_GoogleAnalytics Component: GoogleCheckout Relates to Mage_GoogleCheckout Component: ImportExport Relates to Mage_ImportExport Component: Index Relates to Mage_Index Component: Install Relates to Mage_Install Component: Log Relates to Mage_Log Component: Media Relates to Mage_Media Component: Oauth Relates to Mage_Oauth Component: Page Relates to Mage_Page Component: Paygate Relates to Mage_Paygate Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Mage.php Relates to app/Mage.php
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fballiano @pquerner @addison74 @kiatng