Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incompatible interface deprecations in DB Session Adapter #3497

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Fixed incompatible interface deprecations in DB Session Adapter #3497

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27bef5a
Suppress incompatible interface deprecations in DB Session Adapter
elidrissidev Sep 6, 2023
0bc055f
Directly implement SessionHandlerInterface
elidrissidev Sep 7, 2023
e7a67ce
Merge branch 'main' into fix/db-session-adapter-php8
fballiano Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/code/core/Mage/Core/Model/Resource/Session.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
* @category Mage
* @package Mage_Core
*/
class Mage_Core_Model_Resource_Session implements Zend_Session_SaveHandler_Interface
class Mage_Core_Model_Resource_Session implements SessionHandlerInterface
{
/**
* Session maximum cookie lifetime
Expand Down Expand Up @@ -162,6 +162,7 @@ public static function setStaticSaveHandler()
* @param string $sessName ignored
* @return bool
*/
#[\ReturnTypeWillChange]
public function open($savePath, $sessName)
{
return true;
Expand All @@ -172,6 +173,7 @@ public function open($savePath, $sessName)
*
* @return bool
*/
#[\ReturnTypeWillChange]
public function close()
{
$this->gc($this->getLifeTime());
Expand All @@ -185,6 +187,7 @@ public function close()
* @param string $sessId
* @return string
*/
#[\ReturnTypeWillChange]
public function read($sessId)
{
$select = $this->_read->select()
Expand All @@ -208,6 +211,7 @@ public function read($sessId)
* @param string $sessData
* @return bool
*/
#[\ReturnTypeWillChange]
public function write($sessId, $sessData)
{
$bindValues = [
Expand Down Expand Up @@ -241,6 +245,7 @@ public function write($sessId, $sessData)
* @param string $sessId
* @return bool
*/
#[\ReturnTypeWillChange]
public function destroy($sessId)
{
$where = ['session_id = ?' => $sessId];
Expand All @@ -254,6 +259,7 @@ public function destroy($sessId)
* @param int $sessMaxLifeTime ignored
* @return bool
*/
#[\ReturnTypeWillChange]
public function gc($sessMaxLifeTime)
{
if ($this->_automaticCleaningFactor > 0) {
Expand Down