Fixed implementation of SessionHandlerInterface in Mage_Core_Model_Resource_Session

app/code/core/Mage/Core/Model/Resource/Session.php

@@ -162,8 +162,7 @@ public static function setStaticSaveHandler()
      * @param string $sessName ignored
      * @return bool
      */
-    #[\ReturnTypeWillChange]
-    public function open($savePath, $sessName)
+    public function open($savePath, $sessName): bool
     {
         return true;
     }
@@ -173,8 +172,7 @@ public function open($savePath, $sessName)
      *
      * @return bool
      */
-    #[\ReturnTypeWillChange]
-    public function close()
+    public function close(): bool
     {
         $this->gc($this->getLifeTime());
 
@@ -185,10 +183,9 @@ public function close()
      * Fetch session data
      *
      * @param string $sessId
-     * @return string
+     * @return string|false
      */
-    #[\ReturnTypeWillChange]
-    public function read($sessId)
+    public function read($sessId): string|false
     {
         $select = $this->_read->select()
                 ->from($this->_sessionTable, ['session_data'])
@@ -211,8 +208,7 @@ public function read($sessId)
      * @param string $sessData
      * @return bool
      */
-    #[\ReturnTypeWillChange]
-    public function write($sessId, $sessData)
+    public function write($sessId, $sessData): bool
     {
         $bindValues = [
             'session_id'      => $sessId
@@ -245,8 +241,7 @@ public function write($sessId, $sessData)
      * @param string $sessId
      * @return bool
      */
-    #[\ReturnTypeWillChange]
-    public function destroy($sessId)
+    public function destroy($sessId): bool
     {
         $where = ['session_id = ?' => $sessId];
         $this->_write->delete($this->_sessionTable, $where);
@@ -257,19 +252,18 @@ public function destroy($sessId)
      * Garbage collection
      *
      * @param int $sessMaxLifeTime ignored
-     * @return bool
+     * @return int|false
      */
-    #[\ReturnTypeWillChange]
-    public function gc($sessMaxLifeTime)
+    public function gc($sessMaxLifeTime): int|false
     {
         if ($this->_automaticCleaningFactor > 0) {
             if ($this->_automaticCleaningFactor == 1 ||
                 rand(1, $this->_automaticCleaningFactor) == 1
             ) {
                 $where = ['session_expires < ?' => Varien_Date::toTimestamp(true)];
-                $this->_write->delete($this->_sessionTable, $where);
+                return $this->_write->delete($this->_sessionTable, $where);
             }
         }
-        return true;
+        return false;
     }
 }