-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed jQuery dependencies from swatches in RWD theme #3824
Removed jQuery dependencies from swatches in RWD theme #3824
Conversation
app/design/frontend/rwd/default/template/configurableswatches/catalog/media/js.phtml
Show resolved
Hide resolved
I starting to test this PR and so far seems to work great. I'd prefer to have it on |
In my themes, that don't depend on jquery, I always have to make these changes |
skin/frontend/rwd/default/js/configurableswatches/swatches-list.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from my tests I couldn't see anything wrong with this PR
Description (*)
With this PR, it is possible to extend RWD Theme by inheriting the swatches functionality without the need to unnecessarily load jQuery.
Fixed Issues (if relevant)
Manual testing scenarios (*)
In both cases image gallery must swap with selected option, in PDP price must change if there is a supplement.
PS: It should work in both cases, with and without jQuery.
It is normal to have a lot of console errors related to jQuery used in other JavaScript.
Questions or comments
It has been very helpful for creating lightweight themes. In the future, if we can also eliminate PrototypeJs from the libraries used for configurable products as well, it would be awesome.
Contribution checklist (*)