Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unittest for date and datetime #3833

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Added unittest for date and datetime #3833

merged 2 commits into from
Feb 17, 2024

Conversation

Flyingmana
Copy link
Contributor

No description provided.

@fballiano
Copy link
Contributor

I've no idea how to test this PR, is it running in some workflow?

@Flyingmana
Copy link
Contributor Author

it runs in the sonar workflow

magento-lts/.github/workflows/sonar.yml

Line 48 in e08d889

run: phpunit --configuration ./dev/phpunit.xml.dist --testsuite=Unit;

fballiano
fballiano approved these changes Feb 17, 2024
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, runs alright

@fballiano fballiano changed the title add unittest for data and datetime Added unittest for date and datetime Feb 17, 2024
@fballiano fballiano merged commit 43e8f06 into OpenMage:next Feb 17, 2024
16 checks passed
@sreichel sreichel mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

@kiatng kiatng Awaiting requested review from kiatng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Flyingmana @fballiano @kiatng @addison74