Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed docblock in Mage.php #3836

Closed
wants to merge 1 commit into from
Closed

Conversation

kiatng
Copy link
Contributor

@kiatng kiatng commented Feb 15, 2024

Minor docblock fixes.

@github-actions github-actions bot added the Mage.php Relates to app/Mage.php label Feb 15, 2024
@fballiano
Copy link
Contributor

phpstan became super angry for some reason

@addison74
Copy link
Contributor

The same issue related to PHPStan happened here #3835.

@addison74
Copy link
Contributor

phpstan became super angry for some reason

Adding "false" to docblock requires a check for not being false. E.g. if ($param) ... or something simiar.

@fballiano fballiano marked this pull request as draft February 29, 2024 09:33
@fballiano
Copy link
Contributor

I'll close this at the moment, please reopen it if/when you'll be able to continue working on it

@fballiano fballiano closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mage.php Relates to app/Mage.php
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants