Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix strlen() null deprecation in AccountController.php #4155

Merged
merged 9 commits into from
Sep 6, 2024
Merged

Fix strlen() null deprecation in AccountController.php #4155

merged 9 commits into from
Sep 6, 2024

Conversation

kiatng
Copy link
Contributor

@kiatng kiatng commented Aug 15, 2024

Description (*)

    [type] => 8192:E_DEPRECATED
    [message] => strlen(): Passing null to parameter #1 ($string) of type string is deprecated
    [file] => .../app/code/core/Mage/Customer/controllers/AccountController.php
    [line] => 900
    [uri] => /customer/account/resetpassword/

@github-actions github-actions bot added the Component: Customer Relates to Mage_Customer label Aug 15, 2024
@kiatng kiatng added the PHP 8.1 Related to PHP 8.1 label Aug 15, 2024
sreichel
sreichel previously approved these changes Aug 16, 2024
View reviewed changes
addison74
addison74 previously approved these changes Aug 17, 2024
View reviewed changes
mattdavenport
mattdavenport previously approved these changes Aug 21, 2024
View reviewed changes
kiatng added 2 commits August 26, 2024 13:09
@kiatng
Removed null returned type.
0f73b51
@kiatng
Merge branch 'null_deprecation_accountcontroller' of https://github.c…
e059e16 
…om/kiatng/magento-lts into null_deprecation_accountcontroller

# Conflicts:
#	app/code/core/Mage/Customer/controllers/AccountController.php
@kiatng kiatng dismissed stale reviews from mattdavenport and addison74 via e059e16 August 26, 2024 05:10
@sreichel sreichel merged commit 5fd5e04 into OpenMage:main Sep 6, 2024
15 checks passed
@sreichel sreichel deleted the null_deprecation_accountcontroller branch September 6, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@sreichel sreichel sreichel approved these changes

@mattdavenport mattdavenport mattdavenport left review comments

@colinmollenhour colinmollenhour Awaiting requested review from colinmollenhour

Assignees
No one assigned
Labels
Component: Customer Relates to Mage_Customer PHP 8.1 Related to PHP 8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiatng @mattdavenport @sreichel @addison74